ДЗ7 #84
Open
ДЗ7 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Dec 11, 2020
| <Route path="/" component={() => '404 - not found'} /> | ||
| <Route path="/error" component={ErrorPage} /> | ||
| <Route path="/success" component={() => <h1>Thanks for order!</h1>} /> | ||
| <Redirect from="/" to="/restaurants" /> |
There was a problem hiding this comment.
Redirect с рута лучше ставить самым первым, так мы сразу понимаем, что происходит при первом заходе на /
koretskiyav
reviewed
Dec 11, 2020
| @@ -38,7 +39,11 @@ function BasketItem({ | |||
| small | |||
| /> | |||
| </div> | |||
| <p className={cn(styles.count, styles.price)}>{subtotal} $</p> | |||
| <p className={cn(styles.count, styles.price)}> | |||
| <CurrencyConsumer> | |||
There was a problem hiding this comment.
не самы удобный АПИ получается у фунции конвертации, покажу как удобнее на своей домашке
koretskiyav
reviewed
Dec 11, 2020
| @@ -88,3 +103,13 @@ export const averageRatingSelector = createSelector( | |||
| ); | |||
| } | |||
| ); | |||
|
|
|||
| export const currentRouteSelector = createSelector( | |||
There was a problem hiding this comment.
тут можно использовать селектор из connected-react-router
koretskiyav
reviewed
Dec 11, 2020
| dispatch(replace('/success')); | ||
| } catch (error) { | ||
| dispatch({ type: CHECKOUT + FAILURE, error: error?.message }); | ||
| dispatch(replace('/error', { error: error?.message })); |
There was a problem hiding this comment.
это состояние лучше все таки хранить в redux
koretskiyav
reviewed
Dec 11, 2020
| })), | ||
| [] | ||
| ); | ||
| const [selectedOption, setSelectedOption] = useState([options[0]]); |
There was a problem hiding this comment.
это лишнее состояние, можно взять currency из CurrencyContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Успела сделать редирект на страницу ресторанов, отправку заказа и переключение валют, но без пересчёта значений по курсу (только валюты сами вывела).
Не успела доделать пересчёт валют и CSS-анимации.