ДЗ5 #68
Open
ДЗ5 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Dec 4, 2020
| loading: false, | ||
| loaded: false, | ||
| error: null, | ||
| visited: [], |
There was a problem hiding this comment.
лучше объектом это хранить, удобнее проверка будет
koretskiyav
reviewed
Dec 4, 2020
| averageRating: averageRatingSelector(state, props), | ||
| reviewsLoading: reviewsLoadingSelector(state), | ||
| reviewsLoaded: reviewsLoadedSelector(state), | ||
| visited: hasRestaurantReviewsVisited(state, { |
There was a problem hiding this comment.
лучше так не делать, чтобы потом при изменении переписать только селектор и не трогать connect, то есть писать так - hasRestaurantReviewsVisited(state, props)
There was a problem hiding this comment.
А где тогда лучше переименовать проп id, чтобы в селектор попал именно restaurantId? А то у меня в разных компонентах этот проп по разному называется, а селектор хочется один и тот же использовать
There was a problem hiding this comment.
лучше сделать тогда какую-то обертку над селекторами или разные селекторы иметь
|
отличная работа |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.