HT4 #66
Open
HT4 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Dec 1, 2020
| title: restaurant.name, | ||
| content: <Restaurant restaurant={restaurant} />, | ||
| })); | ||
| const tabs = Object.keys(restaurants).map((restaurantId) => { |
There was a problem hiding this comment.
это нужно выносить в селекторы и мемоизировать.
koretskiyav
reviewed
Dec 1, 2020
| const review = reviewsRestaurantSelector(state)[ownProps.id]; | ||
|
|
||
| return { | ||
| text: reviewsRestaurantSelector(state)[ownProps.id].text, |
There was a problem hiding this comment.
вот эту всю логику лучше описывать в селекторе, что-то вроде reviewsRestaurantSelector(state, ownProps). На занятии расскажу почему.
koretskiyav
reviewed
Dec 1, 2020
|
|
||
| const uuid = (store) => (next) => (action) => { | ||
| const { | ||
| payload: { values }, |
There was a problem hiding this comment.
такая структура может быть не у всех action и тут может буть ошибка, лучше это делать в каждом конкретно switch case, где понятно с каким екшеном мы работаем
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.