merge: Don't output commit message when merging ancestor #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to merge an ancestor of the current HEAD, no changes are made. However, `kart merge -o json` will output a commit message anyway, which is a bit misleading since no commit was made with that message. This change sets the `message` in the JSON output to `null`
craigds
force-pushed
the
merge-ancestor
branch
from
021f2ee
to
68933c0
Compare
olsen232
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to merge an ancestor of the current HEAD, no changes are made. However,
kart merge -o jsonwill output a commit message anyway, which is a bit misleading since no commit was made with that message.This change sets the
messagein the JSON output tonullRelated links:
Checklist: