fix: replace fmt.Sprintf for paths with path.Join

config.example.yaml

@@ -19,7 +19,6 @@ notifications:
     # Resend API Token
     token: ""
     from: ""
-    subject: ""
     replyTo: ""
 cloudProvider:
   hetzner:

internal/cluster/cluster.go

@@ -3,6 +3,7 @@ package cluster
 import (
 	"context"
 	"fmt"
+	"path"
 
 	"github.com/google/uuid"
 	"github.com/hetznercloud/hcloud-go/v2/hcloud"
@@ -103,11 +104,11 @@ func (s *Service) GetCluster(ctx context.Context, ID uuid.UUID) (*models.Cluster
 }
 
 func (s *Service) getProviderName(provider *models.Provider) string {
-	return fmt.Sprintf("%s/%s", s.dirCfg.TemplatesDir(), provider.Name)
+	return path.Join(s.dirCfg.TemplatesDir(), provider.Name)
 }
 
 func (s *Service) getCustomerDir(customer *models.Customer) string {
-	return fmt.Sprintf("%s/%s", s.dirCfg.ClientsDir(), customer.ID)
+	return path.Join(s.dirCfg.ClientsDir(), customer.ID.String())
 }
 
 func (s *Service) BuildCluster(ctx context.Context, customer *models.Customer, providerID uuid.UUID) (*models.Cluster, error) {

internal/k8s/k8s.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"path"
 
 	helmclient "github.com/mittwald/go-helm-client"
 	"helm.sh/helm/v3/pkg/repo"
@@ -35,14 +36,14 @@ func (c *Cluster) InstallCharts() error {
 	}
 
 	// rook-ceph operator values
-	rookCephOperatorValues := fmt.Sprintf("%s/%s", c.chartsDir, rookCephOperatorChartValues)
+	rookCephOperatorValues := path.Join(c.chartsDir, rookCephOperatorChartValues)
 	valuesRookOperatorYaml, err := os.ReadFile(rookCephOperatorValues)
 	if err != nil {
 		return fmt.Errorf("could not load values.yaml for rook-operator: %w", err)
 	}
 
 	// rook-ceph cluster values
-	rookCephClusterValues := fmt.Sprintf("%s/%s", c.chartsDir, rookCephClusterChartValues)
+	rookCephClusterValues := path.Join(c.chartsDir, rookCephClusterChartValues)
 	valuesRookClusterYaml, err := os.ReadFile(rookCephClusterValues)
 	if err != nil {
 		return fmt.Errorf("could not load values.yaml for rook-cluster: %w", err)

internal/ssh/ssh.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"log/slog"
+	"path"
 
 	"github.com/google/uuid"
 	"github.com/koor-tech/genesis/pkg/database"
@@ -41,8 +42,8 @@ func (s *Service) BuildAndRunSSH(ctx context.Context, clusterID uuid.UUID, dirPa
 		return nil, err
 	}
 
-	privateKeyFile := fmt.Sprintf("%s/%s", dirPath, fileKeyName)
-	publicKeyFile := fmt.Sprintf("%s/%s.pub", dirPath, fileKeyName)
+	privateKeyFile := path.Join(dirPath, fileKeyName)
+	publicKeyFile := path.Join(dirPath, fmt.Sprintf("%s.pub", fileKeyName))
 
 	sshModel.PrivateFilePath = privateKeyFile
 	sshModel.PublicFilePath = publicKeyFile

pkg/config/config.go

@@ -64,7 +64,6 @@ type EmailNotifications struct {
 	Token string `yaml:"token"`
 
 	From    string `yaml:"from"`
-	Subject string `yaml:"subject"`
 	ReplyTo string `yaml:"replyTo"`
 }
 

pkg/kubeone/terraform.go

@@ -7,6 +7,7 @@ import (
 	"log/slog"
 	"os"
 	"os/exec"
+	"path"
 	"strings"
 
 	"github.com/hashicorp/terraform-exec/tfexec"
@@ -52,7 +53,7 @@ func (b *Builder) WriteTFVars() error {
 		tfConfigFile = append(tfConfigFile, configLine)
 	}
 
-	tfVars := fmt.Sprintf("%s/%s", b.dst, "terraform.tfvars")
+	tfVars := path.Join(b.dst, "terraform.tfvars")
 	err = utils.SaveInFile(tfVars, strings.Join(tfConfigFile, "\n"), 0600)
 	if err != nil {
 		return err

pkg/notification/email.go

@@ -9,7 +9,10 @@ import (
 	"github.com/resend/resend-go/v2"
 )
 
-const emailText = `Your managed Koor Ceph Cluster is ready to use!`
+const (
+	emailSubject = `Your managed Koor Ceph Cluster is ready to use!`
+	emailText    = `Your managed Koor Ceph Cluster is ready to use!`
+)
 
 type Email struct {
 	Notifier
@@ -25,6 +28,8 @@ type Email struct {
 func NewEmail(logger *slog.Logger, cfg config.EmailNotifications) (Notifier, error) {
 	client := resend.NewClient(cfg.Token)
 
+	// TODO either we use a a separate template "collection" for the notification in general or
+	// a "central" templates object
 	tpl, err := template.New("email").Parse(emailText)
 	if err != nil {
 		return nil, err
@@ -44,8 +49,8 @@ func (n *Email) Send(customer models.Customer) error {
 	params := &resend.SendEmailRequest{
 		To:      []string{customer.Email},
 		From:    n.cfg.From,
-		Subject: n.cfg.Subject,
 		ReplyTo: n.cfg.ReplyTo,
+		Subject: emailSubject,
 		Text:    emailText,
 	}