This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
helm: make scrape timeout configurable #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galexrt
previously approved these changes
Nov 7, 2023
|
@SimonSimonB thank you for your PR! Please bump the patch chart version to |
|
Thanks for the speedy review, @galexrt !
Sorry, forgot about that. It's bumped now. |
|
@SimonSimonB No worries! Sorry, I forgot to tell you to update the helm chart docs when bumping the version. |
simoncampion
force-pushed
the
scrape-timeout
branch
from
733dbc6 to
8c86e3b
Compare
|
Sure thing! I amended the commit. |
galexrt
approved these changes
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR makes the scrape timeout of the
ServiceMonitorgenerated by the Helm chart configurable. This is helpful to fix scrape timeouts if the extended-ceph-exporter needs more time to export metrics than the global timeout settings on a cluster.The MR also introduces a default timeout of 20s in the
values.yamlof the Helm chart. I mainly introduced the default to be consistent with the existingscrapeTimeoutHelm parameter that also defines a default. I'd be happy to remove the default if you prefer.