fix(MenuButton): 14063 Allow to pass popover classname as a prop. Fix passing className prop to MenuList, MenuPopover, DropdownPopover

[albaranau]

We need to pass z-index to MenuPopover, otherwise it gets hidden by panels beneath it. This PR adds classes prop to MenuList, which allows passing popover classname.

It also fixes passing className prop to MenuList, MenuPopover, DropdownPopover (it was not working correctly)

Summary by CodeRabbit

• New Features

  • Enhanced customization options for the MenuList component with the addition of a classes property, allowing users to define specific styles for the MenuPopover.

• Bug Fixes

  • Improved readability and maintainability of class name generation in the DropdownPopover, MenuPopover, and PopoverImpl components without altering their functionality.

[coderabbitai]

Walkthrough

The changes involve modifications to several components within the UI kit, primarily focusing on how class names are constructed and passed to components. The DropdownPopover component's class name handling has been made more modular, while the MenuList component has introduced new properties for enhanced styling flexibility. The MenuPopover and Popover components have undergone formatting adjustments to improve code readability without altering their functionality.

Changes

Files	Change Summary
packages/ui-kit/src/Dropdown/components/DropdownPopover/index.tsx	Modified class name construction in DropdownPopover for improved modularity.
packages/ui-kit/src/MenuButton/components/MenuList/index.tsx	Added classes property for custom styling; modified component implementation to utilize this new prop.
packages/ui-kit/src/MenuButton/components/MenuPopover/index.tsx	Reformatted dynamicClasses variable for better readability; no functional changes.
packages/ui-kit/src/Popover/index.tsx	Reformatted dynamicClasses variable for better readability; no functional changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DropdownPopover
    participant MenuList
    participant MenuPopover
    participant Popover

    User->>DropdownPopover: Interacts with dropdown
    DropdownPopover->>MenuList: Renders menu list
    MenuList->>MenuPopover: Passes custom classes
    MenuPopover->>Popover: Renders popover with styles
    Popover->>User: Displays popover

Loading

Poem

🐇 In the land of code, a change took flight,
Class names danced, oh what a sight!
With props anew, the styles align,
A rabbit's cheer for the code so fine!
Hoppity hop, let the components play,
In the UI garden, they brighten the day! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 7f31539 and 2008af1.

Files selected for processing (1)

• packages/ui-kit/src/MenuButton/components/MenuList/index.tsx (1 hunks)

Additional comments not posted (4)

packages/ui-kit/src/MenuButton/components/MenuList/index.tsx (4)

14-16: LGTM!

The addition of the classes property to the MenuListProps interface is approved as it provides a way to pass custom class names to the MenuPopover component for styling flexibility.

---

19-19: LGTM!

The modification to the MenuList function signature to include the classes parameter is approved as it aligns with the addition of the classes property to the MenuListProps interface.

---

20-25: LGTM!

The code changes for constructing the dynamicClasses variable using the cn function and including the className property are approved.

---

28-28: LGTM!

Passing the classes?.popover property as the className prop to the MenuPopover component is approved as it allows for custom styling of the popover.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

♻️ PR Preview 2008af1 has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 9dcfbea and 7f31539.

Files selected for processing (4)

• packages/ui-kit/src/Dropdown/components/DropdownPopover/index.tsx (1 hunks)
• packages/ui-kit/src/MenuButton/components/MenuList/index.tsx (1 hunks)
• packages/ui-kit/src/MenuButton/components/MenuPopover/index.tsx (1 hunks)
• packages/ui-kit/src/Popover/index.tsx (1 hunks)

Additional comments not posted (5)

packages/ui-kit/src/MenuButton/components/MenuList/index.tsx (2)

20-26: LGTM!

The changes to the MenuList component are approved:

• The destructuring of the className and classes properties aligns with the updated MenuListProps interface.
• The construction of the dynamicClasses variable using the cn function is a common and correct pattern for conditionally applying classes in React components.

---

29-29: LGTM!

The change to pass the classes?.popover value as the className prop to the MenuPopover component is approved. This allows for custom styling of the popover through the classes prop of the MenuList component, enhancing flexibility.

packages/ui-kit/src/MenuButton/components/MenuPopover/index.tsx (1)

24-30: LGTM!

The changes to the dynamicClasses variable construction improve code readability by expanding the object passed to cn into a more explicit block format. This change does not alter the functionality of the MenuPopover component and may facilitate easier future modifications or additions to the class names being applied.

The changes are consistent with the AI-generated summary.

packages/ui-kit/src/Dropdown/components/DropdownPopover/index.tsx (1)

87-87: LGTM!

The changes to the cn function call enhance the flexibility of class name composition and potentially improve readability and maintainability without altering the overall functionality of the DropdownPopover component.

packages/ui-kit/src/Popover/index.tsx (1)

48-53: LGTM!

The changes to the dynamicClasses variable declaration improve code readability by clearly delineating the object being passed to the cn function. The logical functionality remains unaffected.