fix: delete kubefirst file when doing kubefirst reset - KRA-73 #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nathan-nicholson <[email protected]>
…move it Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
patrickdappollonio
previously approved these changes
Dec 10, 2024
Signed-off-by: nathan-nicholson <[email protected]>
patrickdappollonio
approved these changes
Dec 11, 2024
nathan-nicholson
deleted the
nathan/kra-73-delete-kubefirst-file-when-doing-kubefirst-reset
branch
jokestax
pushed a commit
that referenced
this pull request
Jan 6, 2025
--------- Signed-off-by: nathan-nicholson <[email protected]>
jokestax
added a commit
that referenced
this pull request
Jan 6, 2025
* add validation for aws ami type * fix lint * dependency for bottlerocket * update api * fix lint * resolve validate credentials * add test cases * move up the logger * more tests * fix lint * fix suggestions * fix tests * fix suggestion * use slices * fix print stmt * delete duplicate * fix lint * fix print stmt * fix spelling * fix tests * chore: make the mock function signature match the interface Signed-off-by: nathan-nicholson <[email protected]> * chore: fix the ValidateCredentials test to use ErrorContains Signed-off-by: nathan-nicholson <[email protected]> * chore: update ssm mock to use dynamic def of GetParameters Signed-off-by: nathan-nicholson <[email protected]> * chore: more test refactoring Signed-off-by: nathan-nicholson <[email protected]> * chore: remove unused attributes Signed-off-by: nathan-nicholson <[email protected]> * chore: remove commented out code Signed-off-by: nathan-nicholson <[email protected]> * fix: update paginator mock to be more flexible Signed-off-by: nathan-nicholson <[email protected]> * Reduce test complexity. * Apply suggestions from code review Co-authored-by: Patrick D'appollonio <[email protected]> * set next macro chart for kubefirst - 2.7.8-rc6 * set next macro chart for kubefirst - 2.7.8-rc7 * docs: add azure to the readme (#2343) * chore: remove unused GitHub Workflow for devrel (#2346) * fix: delete kubefirst file when doing kubefirst reset - KRA-73 (#2344) --------- Signed-off-by: nathan-nicholson <[email protected]> * set next macro chart for kubefirst - 2.7.8-rc8 * set next macro chart for kubefirst - 2.7.8-rc9 * set next macro chart for kubefirst - 2.7.8-rc10 * set next macro chart for kubefirst - 2.7.9-rc1 * set next macro chart for kubefirst - 2.7.9-rc2 * set next macro chart for kubefirst - 2.7.9-rc3 * set next macro chart for kubefirst - 2.7.9-rc4 * set next macro chart for kubefirst - 2.7.9 * fix: pass CF_ORIGIN_CA_ISSUER_API_TOKEN to API (#2347) * set next macro chart for kubefirst - 2.7.10-rc1 * remove vultr and google out of beta (#2351) * set next macro chart for kubefirst - 2.7.10-rc2 * set next macro chart for kubefirst - 2.7.10-rc3 * fix(azure): change GCP ref in CLI docs to Azure (#2353) * set next macro chart for kubefirst - 2.7.10-rc4 * fix: go indent * fix: fumpt --------- Signed-off-by: nathan-nicholson <[email protected]> Co-authored-by: nathan-nicholson <[email protected]> Co-authored-by: Patrick D'appollonio <[email protected]> Co-authored-by: konstruct-bot <[email protected]> Co-authored-by: Simon Emms <[email protected]> Co-authored-by: Frédéric Harper <[email protected]> Co-authored-by: Muse Mulatu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First PR! 🎉
This removes the
.kubefirstfile that lives at the root alongside the.k1directory. Without removing this file, kubefirst hangs after validating git configuration and never tries to spin up the local cluster for initial setup if there is a partially completed run gumming things up.Related Issue(s)
Fixes #reset
How to test
Couldn't find any existing tests 🤔