Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a section to the intro about contributing #68

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

konstructcarrie
Copy link
Contributor

Description

Adding a paragraph about contributing to docs

Related Issue(s)

#36

How to test

Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are line breaks in middle of sentences.

@konstructcarrie
Copy link
Contributor Author

There are line breaks in middle of sentences.

I think it's because of this auto-wrap thing. Ugh. Let me fix it

@fharper
Copy link
Contributor

fharper commented Dec 16, 2024

Yeah, years ago, people use to break line even in the middle of sentences at column 80. It was useful before we have better IDEs like today, but now it make text more difficult to read, update, and lint, so we decided not to do that on the docs. You could reconsider if you want, just sharing some context on the decision not to do it :)

@fharper
Copy link
Contributor

fharper commented Dec 16, 2024

@konstructcarrie did you also wanted to update the package-lock.json file?

@konstructcarrie
Copy link
Contributor Author

@konstructcarrie did you also wanted to update the package-lock.json file?

Yep, just forgot to add it to the commit notes

@konstructcarrie konstructcarrie merged commit bf77949 into main Dec 16, 2024
10 checks passed
@konstructcarrie konstructcarrie deleted the opensource-contribution branch December 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants