-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #11 add settings to the plugin #33
Open
SalahAdDin
wants to merge
89
commits into
konstantinmuenster:main
Choose a base branch
from
SalahAdDin:feat/configurable-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: #11 add settings to the plugin #33
SalahAdDin
wants to merge
89
commits into
konstantinmuenster:main
from
SalahAdDin:feat/configurable-settings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: adding scroll to editor content
chore: adding localization to the editor
feat: extension abbr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It adds settings routes, configuration, services, and controllers for loading default and saved settings.
Why is it needed?
Content managers want to customize the editor toolbar and features, so we give them a mechanism for doing that.
How to test it?
Add the desired settings on your plugin notification(plugin.ts):
Run the project and go to the content type, choose any of the created entities, and check the editor toolbar.
You can go to settings and look for RichText Editor settings, check your desired settings on the page, modify them, save them, and check on the content type entities that your changes are reflected.
Notes