Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #14 add audio support #26

Open
wants to merge 119 commits into
base: main
Choose a base branch
from

Conversation

SalahAdDin
Copy link

@SalahAdDin SalahAdDin commented Sep 14, 2024

What does it do?

It adds support for inserting audio into the content.

Why is it needed?

Content managers want to add audio, such as records, declarations, etc.

How to test it?

Click on the music icon and select the file from the media library you want to insert into the content.

image

Notes

  • Media Library Dialog presents all existing files despite we just allowed "audios":
    Screenshot_20240913_150900
  • It requires merging the prior PR.
  • There is a backend bug when choosing any audio to insert:
[2024-09-14 21:29:15.090] http: GET /uploads/Sound_Helix_Song_5897482e0a.mp3 (2 ms) 206

  Error: write ECONNRESET
      at afterWriteDispatched (node:internal/stream_base_commons:161:15)
      at writeGeneric (node:internal/stream_base_commons:152:3)
      at Socket._writeGeneric (node:net:953:11)
      at Socket._write (node:net:965:8)
      at doWrite (node:internal/streams/writable:590:12)
      at clearBuffer (node:internal/streams/writable:774:7)
      at Writable.uncork (node:internal/streams/writable:523:7)
      at connectionCorkNT (node:_http_outgoing:981:8)
      at process.processTicksAndRejections (node:internal/process/task_queues:81:21)

webpack compiled successfully
No errors found.

fix: adding scroll to editor content
chore: adding localization to the editor
@SalahAdDin SalahAdDin changed the title feat: #14 add video support feat: #14 add audio support Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant