-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #6 add Alert extension to the editor #18
Open
SalahAdDin
wants to merge
36
commits into
konstantinmuenster:main
Choose a base branch
from
SalahAdDin:feat/extension-alert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: #6 add Alert extension to the editor #18
SalahAdDin
wants to merge
36
commits into
konstantinmuenster:main
from
SalahAdDin:feat/extension-alert
+1,391
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: adding scroll to editor content
chore: adding localization to the editor
feat: extension abbr
fix: dialogs in folder
feat: character and words count display
Hey @SalahAdDin and thanks a ton for all your work 💛 I am little busy these days so I haven't had the chance yet to review the PRs - but I try to get to it soonish! |
@konstantinmuenster Thanks, I will continue adding some other extensions, maybe also the customizable options, this package will be very useful for all content managers. |
SalahAdDin
changed the title
feat: #6 adding Alert extension to the editor
feat: #6 add Alert extension to the editor
Aug 20, 2024
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It adds an alert extension to the editor.
The alerts can be one out of four options and their type can be set after creating the alert from the alert toolbar.
Why is it needed?
Some content editors would want to highlight content and alerts will be a good way to do that.
How to test it?
Write your content, go to the block selector and choose alert, click on the alert type you want from the alert toolbar.
Screencast_20240723_213251.webm
Notes
It requires merging the following the PR above.
Based on the EdifficeUI Tiptap abbreviation extension.