Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the FBC related image validation #1801

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions task/validate-fbc/0.1/validate-fbc.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# TODO:
# make this task fail if a bundle is an image index reference
# change the related-image check to be done in EC with exported related images instead of
# including it in the TEST_OUTPUT result
# Use the new function in konflux-test to only get the unreleased related images
apiVersion: tekton.dev/v1
kind: Task
metadata:
Expand Down Expand Up @@ -478,14 +478,14 @@ spec:
note="Step extract-and-validate completed: Check result for task result."
if [ $TESTPASSED == false ]; then
ERROR_OUTPUT=$(make_result_json -r FAILURE -f $failure_num -s $((check_num - failure_num)) -t "$note")
echo "${ERROR_OUTPUT}" | tee "$(results.TEST_OUTPUT.path)"
echo -n "${ERROR_OUTPUT}" | tee "$(results.TEST_OUTPUT.path)"
else
TEST_OUTPUT=$(make_result_json -r SUCCESS -s $check_num -t "$note")
echo "${TEST_OUTPUT}" | tee "$(results.TEST_OUTPUT.path)"
echo -n "${TEST_OUTPUT}" | tee "$(results.TEST_OUTPUT.path)"
fi
popd
- name: save-related-images
image: quay.io/konflux-ci/oras:latest@sha256:66ccc8c3698304036a42739f6e1836f3399a46645be2d3c5d6d456b9c79fff40
image: quay.io/konflux-ci/oras:latest@sha256:c68c23fe7bb1ba9fc335192761ea94fc2c9beb701f3c205890581ff62fd38d80
script: |
#!/usr/bin/env bash
set -euo pipefail
Expand Down
Loading