Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KFLUXVNGD-93): Update eaas-provision-space task #1789

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

hmariset
Copy link
Contributor

@hmariset hmariset commented Jan 6, 2025

Update eaas-provision-space task to use new claim resource instead of SpaceRequests.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-93

@hmariset hmariset requested a review from a team as a code owner January 6, 2025 17:17
@hmariset hmariset force-pushed the KFLUXVNGD-93 branch 10 times, most recently from d822041 to 0811403 Compare January 8, 2025 02:31
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why Github requested a review from build-maintainers, just commenting to get this PR off our to-review list

@hmariset
Copy link
Contributor Author

hmariset commented Jan 8, 2025

Build pipeline passed successfully.
image
image

@hmariset
Copy link
Contributor Author

hmariset commented Jan 8, 2025

Not sure why Github requested a review from build-maintainers, just commenting to get this PR off our to-review list

Sorry @chmeliik it was added automatically and I don't see the option to remove

@chmeliik
Copy link
Contributor

chmeliik commented Jan 8, 2025

Not sure why Github requested a review from build-maintainers, just commenting to get this PR off our to-review list

Sorry @chmeliik it was added automatically and I don't see the option to remove

No problem, I removed the review request by posting that comment 🙂

@hmariset hmariset force-pushed the KFLUXVNGD-93 branch 3 times, most recently from df6d0f4 to 657c08c Compare January 8, 2025 17:30
Update eaas-provision-space task to use new claim resource
instead of SpaceRequests.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-93
Signed-off-by: Homaja Marisetty <[email protected]>
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hmariset hmariset added this pull request to the merge queue Jan 8, 2025
Merged via the queue into konflux-ci:main with commit 4e4fa73 Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants