Validate added migration file #1772
Open
+384
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdchen
force-pushed
the
STONEBLD-2827-setup-ci-for-migration
branch
3 times, most recently
from
23818af to
f0fe270
Compare
tkdchen
force-pushed
the
STONEBLD-2827-setup-ci-for-migration
branch
from
f0fe270 to
bf71ad7
Compare
tkdchen
force-pushed
the
STONEBLD-2827-setup-ci-for-migration
branch
12 times, most recently
from
f8216f0 to
35693f1
Compare
chmeliik
reviewed
Jan 2, 2025
chmeliik
reviewed
Jan 2, 2025
tkdchen
force-pushed
the
STONEBLD-2827-setup-ci-for-migration
branch
from
3419ce7 to
e5b84a2
Compare
chmeliik
reviewed
Jan 8, 2025
hack/validate-migration.sh
Outdated
| case "$status" in | ||
| A) # file is added | ||
| task_dir_path=$(awk -F '/' '{ OFS = "/"; print $1, $2 }' <<<"$origin_path") | ||
| if grep -q "$task_dir_path" <<<"$seen"; then |
There was a problem hiding this comment.
I think this will cause problems
$ grep -q "task/buildah" <<< "task/buildah-remote task/some-other-task" && echo already seen
already seenMaybe change the seen variable to be multiline and check like this?
grep -q "^${task_dir_path}$" <<< "$seen"There was a problem hiding this comment.
Good catch. Updated.
tkdchen
force-pushed
the
STONEBLD-2827-setup-ci-for-migration
branch
2 times, most recently
from
ebd6ba2 to
3821d6e
Compare
|
Rebased this PR in order to base on the fix #1788 |
chmeliik
reviewed
Jan 9, 2025
STONEBLD-2827 A few checks are introduced by this commit. Please refer to individual check_ functions for detailed information. Signed-off-by: Chenxiong Qi <[email protected]>
tkdchen
force-pushed
the
STONEBLD-2827-setup-ci-for-migration
branch
from
3821d6e to
a55f38d
Compare
|
Squash is done. |
chmeliik
approved these changes
Jan 9, 2025
|
/test build-definitions-pull-request |
|
/test build-definitions-pull-request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STONEBLD-2827
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.