Make scale work for std::execution::par #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document option in README.md.
... macro with LINALG_HAS_EXECUTION. In the next commit, we'll conditionally define it in a common place.
Make sure that LINALG_ENABLE_TBB is defined as a macro, if set as a CMake option. It's conditionally defined in the generated header file linalg_config.h (which already exists and conditionally defines other macros). Also, make sure that macros.hpp includes the generated header file linalg_config.h. Given that linalg_config.h already had macros defined in it, other stdBLAS headers really should have been including it.
Customization point execpolicy_mapper remains the same, but algorithms now use it in a wrapper that checks the return type, to ensure that infinite recursion errors are checked at compile time. Also, fix <execution> header include guard.
Use ranges (views::iota, optionally also views::cartesian_product) to make the algorithm work for any mdspan with unique layout.
|
@amklinv-nnl this could be helpful for informing your parallelization efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
scalework forstd::execution::par.This is rebased atop PR #256; please merge that first; thanks!