-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HPX backend #235
base: main
Are you sure you want to change the base?
Adding HPX backend #235
Conversation
@@ -0,0 +1,108 @@ | |||
# Copyright (c) 2016 Thomas Heller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR includes a .clang-format file. Are you suggesting this as a code formatting standard for the project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't suggest using this formatting style. I guess I suggest using any .clang-format
to simplify contributions. The file I used was simply taken from HPX (with minor changes). Do you have any coding guidelines for this project? I'd be happy to adapt everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkaiser An excellent idea! Ideally I would like the code to be formatted like the C++ Standard document. I don't think clang-format has a standard preset for that. I'll ask around for how to do this.
tpl-implementations/include/experimental/__p1673_bits/hpx-kernels/blas1_add_hpx.hpp
Show resolved
Hide resolved
tpl-implementations/include/experimental/__p1673_bits/hpx-kernels/blas1_add_hpx.hpp
Outdated
Show resolved
Hide resolved
@mhoemmen could you possibly approve the GitHub action execution for this PR? This would enable me to set up the HPX testing environment. |
b0d09fe
to
857425c
Compare
- added build system support and test infrastructure - added .clang-format configuration file - added BLAS1 add (1d and 2d) - added BLAS1 scale (1d and 2d) - added GitHub action
- flyby: minor tweak to CMakeLists.txt (detect KokkosKernels quietly) - flyby: adding workaround for MSVC to transposed.hpp
This is a very rudimentary implementation of an HPX backend, essentially mostly a proof of concept.
Implemented functions:
scale
add
The HPX backend will be triggered if one of the HPX execution policies is passed to one of the API functions, e.g.
This also contains the necessary build system and testing infrastructure. I'm creating this PR mainly to be able to set up a github action that would run the tests using the HPX backend.