Test with SYCL in the CI #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
test_sycl_ci
branch
from
6ca96a1
to
5c448fb
Compare
keryell
reviewed
May 17, 2023
| #include <sycl/sycl.hpp> | ||
| #else | ||
| #include <CL/sycl.hpp> |
There was a problem hiding this comment.
Perhaps this SYCL implementation does not provides this deprecated SYCL 1.2.1 header now?
There was a problem hiding this comment.
Yeah, this one only had the deprecated header. Not quite sure if updating the compiler in the CI is worth it for this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #234. This pull request makes the
icpxtest withSYCL.I also added
--output-on-failuretoCTestand needed to allowCL/sycl.hppinstead ofsycl/sycl.hppfor olderoneAPIreleases. The header checks needsC++17butSYCLneeds C++17 support anyway.