-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support in place transform #149
Support in place transform #149
Conversation
48e8072
to
7e00da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that fftw, cufft and hipfft internally do a check for an in-place execution ? No need to modify anything on our side ?
Thank you for reviews I expect that |
That is also my understanding reading cufft. |
7e00da4
to
1788f06
Compare
@tpadioleau |
@tpadioleau |
Not precise enough otherwise ? |
Maybe. |
@tpadioleau Seems OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me
@tpadioleau Thank you for review. I think I have fixed accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
I will merge this. Thank you again for your review |
Resolves #61
This PR aims at supporting in-place transform.
Following changes are made.
are_aliasing
to check if the input and output views are aliasare_aliasing
get_extents
function to compute extents forin-place
casein-place
options forROCM
andSYCL
in case ofin-place
transformsin-place
transforms