-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ubuntu: test intel compiler #50
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a proper description for this PR
What issue is it resolving?
What changed? Is your intent to prevent the image to build if the icpx --version
command fails?
Sorry, there was a problem that the path for |
I am fine with these changes (essentially adding a safeguard for future builds) but I am a bit confused since it is not accompanied with any update to the base image which presumably means that there is no real issue being resolved. |
Yeah I wasn't able to understand how the build error in Cabana was triggered @streeve do you know? |
After we merged ECP-copa/ci-containers/pull/31, the Cabana CI broke where This won't guard against us doing the same thing later on (and I'm pretty sure merging ECP-copa/ci-containers/pull/32 will pass if the Kokkos base is rebuilt and fail if not, same as the eventual Cabana CI itself) |
@streeve do we still need this? |
No, I don't think so - as far as I can tell the easiest way to fix this for good would be to deploy the current CoPA container here as well |
ECP-copa/Cabana#740 (comment)