Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu: test intel compiler #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ubuntu: test intel compiler #50

wants to merge 1 commit into from

Conversation

junghans
Copy link
Collaborator

@junghans junghans commented Mar 20, 2024

@junghans junghans marked this pull request as ready for review April 1, 2024 15:48
@junghans junghans requested a review from dalg24 April 1, 2024 15:48
@junghans junghans enabled auto-merge April 1, 2024 15:48
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a proper description for this PR
What issue is it resolving?
What changed? Is your intent to prevent the image to build if the icpx --version command fails?

@junghans
Copy link
Collaborator Author

junghans commented Apr 1, 2024

Sorry, there was a problem that the path for icpx changes somewhen during a version bump and we only caught it down at the cabana level, so it would be good to test if the compiler can actually be found.

@dalg24
Copy link
Member

dalg24 commented Apr 1, 2024

I am fine with these changes (essentially adding a safeguard for future builds) but I am a bit confused since it is not accompanied with any update to the base image which presumably means that there is no real issue being resolved.
What am I missing?

@junghans
Copy link
Collaborator Author

junghans commented Apr 2, 2024

Yeah I wasn't able to understand how the build error in Cabana was triggered

@streeve do you know?

@streeve
Copy link

streeve commented Apr 2, 2024

After we merged ECP-copa/ci-containers/pull/31, the Cabana CI broke where icpx can't be found. @junghans added this to make sure the same issue wasn't present here, but by rebuilding it here the problem was also fixed downstream

This won't guard against us doing the same thing later on (and I'm pretty sure merging ECP-copa/ci-containers/pull/32 will pass if the Kokkos base is rebuilt and fail if not, same as the eventual Cabana CI itself)

@junghans
Copy link
Collaborator Author

@streeve do we still need this?

@streeve
Copy link

streeve commented Sep 10, 2024

@streeve do we still need this?

No, I don't think so - as far as I can tell the easiest way to fix this for good would be to deploy the current CoPA container here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants