Added add and multiply inline operations #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case, which I consider fairly common:
Multiply or add a number smaller than WORD_SIZE bytes, to a given bignum (myBigNum in below example).
The library currently supports this by doing something like this:
int k = 1234;
struct bn tmp;
bignum_from_int(&tmp, k);
struct bn intermediate;
bignum_mul(&tmp, &myBigNum, &intermediate);
bignum_assign(&myBigNum, &intermediate);
The multiply operation is quite expensive because of internal O(n^3) implementation. When doing a large number of these operations it will dominate the execution time.
My proposal here is to add two simple inline operations that multiply with a DTYPE integer.
These are much faster than regular add/mul, and a bit more convenient in usage. The above code becomes:
bignum_mul_int(&myBigNum, k);