Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added add and multiply inline operations #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bkrogh
Copy link

@bkrogh bkrogh commented Apr 10, 2020

I have a case, which I consider fairly common:
Multiply or add a number smaller than WORD_SIZE bytes, to a given bignum (myBigNum in below example).

The library currently supports this by doing something like this:
int k = 1234;
struct bn tmp;
bignum_from_int(&tmp, k);

struct bn intermediate;
bignum_mul(&tmp, &myBigNum, &intermediate);
bignum_assign(&myBigNum, &intermediate);

The multiply operation is quite expensive because of internal O(n^3) implementation. When doing a large number of these operations it will dominate the execution time.

My proposal here is to add two simple inline operations that multiply with a DTYPE integer.
These are much faster than regular add/mul, and a bit more convenient in usage. The above code becomes:
bignum_mul_int(&myBigNum, k);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant