-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(projectHistoryLogs): project history logs for bulk actions TASK-1229 #5270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- It was super not-obvious on the task (sorry) but we only need to worry about bulk archiving and non-archiving.
- Can we stick with the pattern of adding things to the request, then going through ProjectHistoryLog.create_from_request? It is easier to reason about if the code all generally flows through one place
1b4759c
to
b89353d
Compare
…s mechanisms, fix tests
593bc8c
to
e05ceef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change in db usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234
frontend
orbackend
unless it's global📖 Description
This PR adds support for bulk actions logging.
👀 Preview steps
💭 Notes