Allow concat in frontend t()-string sources #4945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safely allow string concatenation in frontend translated strings.
Purpose
Details
Supports usage like
Without this fix, examples like the above would be missing from the build output without warning.1 If you compare
extracted-strings.json
before and afterwards you'll see maybe 8 or 9 translation strings turn up that were previously missing. Some of them can be seen here: GitHub search 🔎I wrote some more explanation about how this patch works in my upstream PR 🍴 on grassator/webpack-extract-translation-keys.
Related issues
Part of #4944
Checklist
If you've changed APIs, update (or create!) the documentationOpen an issue in the docs if there are UI/UX changesFootnotes
Previously discussed here and here (internal links) ↩