Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API v2 urls in unit tests languages & audit_log apps #4863

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Feb 28, 2024

Description

v1 is deprecated and new code should use v2 endpoints.

Notes

Apps urls are now included in API v2 Router instead of being added in url_patterns.
It lets Django pass the namespace in the viewname (e.g. reverse(<namespace>:<viewname>))

Related issues

Part of #4743

@noliveleger noliveleger changed the title Refactor api v2 urls Use API v2 urls in unit tests languages & audit_log apps Feb 28, 2024
@noliveleger noliveleger marked this pull request as ready for review February 28, 2024 17:37
@noliveleger noliveleger requested a review from bufke February 28, 2024 17:38
Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm. If all you need to do is take my suggestion and delete a couple lines, then please go ahead and merge once CI passes.

kpi/urls/router_api_v2.py Show resolved Hide resolved
Base automatically changed from refactor-counter-shadow-models to release/2.024.09 March 11, 2024 14:19
@noliveleger noliveleger merged commit 65a87b5 into release/2.024.09 Mar 11, 2024
4 checks passed
@noliveleger noliveleger deleted the refactor-api-v2-urls branch March 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants