Skip to content

Commit

Permalink
code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
magicznyleszek committed Jul 31, 2024
1 parent cfb6087 commit 21ba6a1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions jsapp/js/components/formSummary.scss
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
color: colors.$kobo-gray-40;
border-bottom: 1px solid colors.$kobo-gray-92;
position: relative;
text-align: initial;

&:last-child {
border-bottom: none;
Expand Down
2 changes: 1 addition & 1 deletion jsapp/js/components/formSummaryProjectInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default function FormSummaryProjectInfo(
{metadata.description && (
<bem.FormView__group m='items'>
{/* description - takes whole row */}
<bem.FormView__cell m='padding'>
<bem.FormView__cell m={['padding', 'full-width']}>
<bem.FormView__label>
{metadata.description?.label ?? t('Description')}
</bem.FormView__label>
Expand Down
4 changes: 4 additions & 0 deletions jsapp/scss/components/_kobo.form-view.scss
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,10 @@ $side-tabs-width-mobile: 70px;
padding: 10px 20px;
}

&.form-view__cell--full-width {
width: 100%;
}

// preferably with or inside .form-view__cell--first
&.form-view__cell--label {
font-size: variables.$base-font-size;
Expand Down

0 comments on commit 21ba6a1

Please sign in to comment.