Default redis DB numbers to 0 and 1 TASK-790 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olive-KTB
approved these changes
Nov 19, 2024
noliveleger
reviewed
Nov 19, 2024
| # - KPI Broker - 1 | ||
| # - Kobocat Broker - 1 | ||
| # - KPI Cache - 1 | ||
| # - Service account - 1 |
There was a problem hiding this comment.
For the record: Going to be gone soon
noliveleger
reviewed
Nov 19, 2024
| @@ -91,8 +91,8 @@ kpi: | |||
| secret: | |||
| {} | |||
| # DATABASE_URL: "postgres://postgres:password@postgres-postgresql:5432/postgres" | |||
| # CELERY_BROKER_URL: "redis://localhost:6379/2" | |||
| # CACHE_URL: "redis://localhost:6379/4" | |||
| # CELERY_BROKER_URL: "redis://localhost:6379/1" | |||
There was a problem hiding this comment.
Could this create zombie tasks? (e.g. workers and broker not speaking to each other until the deployment is totally done?)
noliveleger
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate redis DB numbers to just 0 and 1. Simplifies configuration and gets us closer to supporting redis cluster. Since we aren't changing enketo nor sessions - this change should be safe to make without any data migration.