-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disaggregated stats wrong total #191
Open
noliveleger
wants to merge
8
commits into
main
Choose a base branch
from
190-get-disaggregated-stats-bad-total
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
01fef37
Fixed bad calculation of provided response for reports with disaggreg…
noliveleger 860e4be
Fixed calculation of disaggregate stats when some submissions do not …
noliveleger 0b007c3
Added a unittest for disaggregated stats with empty answers
noliveleger 96a8376
Merge master into 190-get-disaggregated-stats-bad-total branch
noliveleger e7c86d4
Merge branch 'master' into 190-get-disaggregated-stats-bad-total
noliveleger ef951a0
Merge branch 'master' into 190-get-disaggregated-stats-bad-total
noliveleger 553ecd8
Add more submissions with null values and test the total count
noliveleger 43e3aa0
Fixed typo
noliveleger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble figuring out where this happens. I found these:
formpack/src/formpack/reporting/autoreport.py
Lines 161 to 162 in 09c600f
formpack/src/formpack/reporting/autoreport.py
Lines 84 to 85 in 09c600f
...but they both increment
counter['__submissions__']
only when the value is notNone
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jnm,
Let's say, we have a form with two questions (select one), not mandatory:
Favorite coffee:
Type of coffee:
Three users submit data (first case):
First one:
- Favorite coffee:
Nespresso
- Type of coffee:
Regular
Second one:
- Favorite coffee:
Tim Horton
- Type of coffee:
Latte
Third one:
- Favorite coffee:
Keurig
- Type of coffee:
No choices checked
Disaggregating the stats by grouping by
Favorite coffee
should return 3Counter
sNone
=>{'keuring': 1}
Latte
=>{'tim_horton': 1}
Regular
=>{'nespresso': 1}
Now, a fourth user submits this (second case):
- Favorite coffee:
No choices checked
- Type of coffee:
latte
It should still return the 3 sames counters, except that
Latte
Counter should have changed for{'None': 1, 'tim_horton': 1}
Having that said, the
if
condition handles the first case, theelse
handles the second one.