forked from getodk/collect
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ODK Collect v2024.3.3 release #14
Open
tiritea
wants to merge
789
commits into
kobotoolbox:master
Choose a base branch
from
tiritea:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of DynamicPreloadExtra not its value
Update JavaRosa
Include DynamicPreloadExtra in formDef only if a form contains search or pulldata
Stop creating entities with missing labels
Filter out case-insensitive duplicate properties
Upgrade to JavaRosa 5.0.0
Don't require a label for Entity updates
Do not format entity values that are build using XPath expressions
Update translations
Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: Emmanuel Ferdman <[email protected]>
Fix list names with special characters
Address review comments for PR 6118, 6169, 6175
Signed-off-by: Emmanuel Ferdman <[email protected]>
Update style guidelines in `CONTRIBUTING.md`
Do not create entities with blank labels
Inflated missing menu
Fixed the filtering of duplicate columns
Throw an exception when there is an attempt to access file outside of Collect directory
Fixed the filtering of duplicate columns
Changes for v2024.3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Why is this the best possible solution? Were any other approaches considered?
Updates KoboCollect to latest changes contained in ODK Collect v2024.3.3, plus requisite Kobo rebranding (reapplied as needed)
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Have run the base ODK unit and most UI tests, after applying Kobo rebranding changes. Baseline tests behave the same as pristine ODK Collect v2024.3.3. All identified tests that now fail are due to rebranding not being applied to the testcase asserts; the core functionality remains correct and consistent with base ODK Collect v2024.3.3 behavior.
However, I have been unable to reliably run all the automated UI tests, due to a recurring OOM (out-of-memory) error from gradle, after about 100 tests. I've attempted to force gradle to run everything serially and continue after failures (specificallly, gradle Pparallel=1 --max-workers=1 --continue ) but this doesn't appear to make much difference. Running the individual testcases that fails - due to reported OOM error - always succeed. So I believe these failures are a consequence of gradle attempting to run the entire testsuite and possibly not cleaning up after each testcase.
Note, this same behavior is observed attempting to run connectedAndroidTest against an unmodified ODK Collect fork. It is also of note that this behavior is new; I was able to successfully run the entire automated UI tests (both customized KoboCollect as well as base ODK Collect) in previous v2024.2.4.
I have also successfully run multiple regression test forms, including the de facto all-widgets form, against rebranded KoboCollect.
Do we need any specific form for testing your changes? If so, please attach one.
no Kobo-specific test forms required; base KoboCollect functionality remains same as ODK Collect.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
TDB if any of the new functionality exposed by ODK Collect needs to be specifically called out in KoboToolbox user doc. But we may want to update Kobo docs with the new features added in ODK Collect v2024.2.4 and v2024.3.3 (eg geofence)
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
)and confirmed all checks still passTO THE EXTENT POSSIBLE (see comments above)DateFormatsTest