Allow configuring app directory/path binaries are placed into #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently hardcoded 'ko-app' app directory was used as a hardcoded string in several places in gobuild. To simplify making it overwritable, all occurances are extraced into a constant for the default value.
An option is added to overwrite the default /ko-app folder to place app binaries in. This can be set via cmd line flag or as a default in the config file.
UnseenWizzard
commented
Sep 20, 2024
| entryPointBasePath string | ||
| } | ||
|
|
||
| func validateImage(t *testing.T, img oci.SignedImage, baseLayers int64, creationTime v1.Time, opts validationOptions) { |
There was a problem hiding this comment.
note that baseLayers being 3 in all test uses triggers the linter - as it's unrelated to the change, I didn't want to change the function to appease the linter. lmk if I should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a way to allow optionally modifying under which path binaries are placed inside containers built with ko - as raised in issue #944
Without deeper insight into the code base, this seems like a straightforward addition with limited impact on future maintainability to me - while allowing users migrating to ko to still place binaries in the same location as their previous Docker containers.
Looking forward to your input and any suggestions!