Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all linter warnings #15684

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Fix all linter warnings #15684

wants to merge 35 commits into from

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 13, 2025

Fixes: #14692

This should unblock PRs that are being gated on the linter checks

Changes are broken down by linter fix

Copy link

knative-prow bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from izabelacg and skonto January 13, 2025 03:47
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2025
@dprotaso dprotaso changed the title Linter Fix all Linter warnings Jan 13, 2025
@dprotaso dprotaso changed the title Fix all Linter warnings Fix all linter warnings Jan 13, 2025
@dprotaso
Copy link
Member Author

/assign @skonto

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 84.02778% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (c2f2b8b) to head (86b4390).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/schema-tweak/overrides.go 0.00% 5 Missing ⚠️
pkg/reconciler/route/route.go 16.66% 5 Missing ⚠️
cmd/activator/main.go 0.00% 2 Missing ⚠️
cmd/schema-tweak/main.go 0.00% 2 Missing ⚠️
pkg/queue/sharedmain/handlers.go 0.00% 2 Missing ⚠️
cmd/default-domain/main.go 0.00% 1 Missing ⚠️
pkg/activator/handler/concurrency_reporter.go 75.00% 1 Missing ⚠️
pkg/activator/net/lb_policy.go 50.00% 1 Missing ⚠️
pkg/autoscaler/statforwarder/leases.go 80.00% 1 Missing ⚠️
pkg/queue/sharedmain/servers.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15684      +/-   ##
==========================================
- Coverage   80.81%   80.80%   -0.02%     
==========================================
  Files         222      222              
  Lines       18034    18025       -9     
==========================================
- Hits        14575    14565      -10     
  Misses       3089     3089              
- Partials      370      371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

kourier-tls
/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all lint warnings
2 participants