Add support for hostPath #15648

amarflybot · 2024-12-09T13:53:18Z

Description

This feature introduces support for the hostPath volume type in Knative Serving, enabling users to mount directories from the host node’s filesystem into their service containers. This allows direct access to node-specific data or preloaded resources like certificates, enhancing flexibility while retaining Knative’s serverless capabilities.

Proposed Changes

Add support for the hostPath volume type in Knative Serving.
Enable users to mount directories from the host node's filesystem into their Knative service containers.
Update relevant documentation and examples to include usage of hostPath volumes.

Release Note


Adding support for the "hostPath" volume type. The feature allows users to mount directories from the host node's filesystem into their Knative service containers. It enables access to local storage on the node, facilitating use cases such as accessing node-specific data or utilizing local caches. The feature is behind the flag `kubernetes.podspec-volumes-hostpath`.

linux-foundation-easycla · 2024-12-09T13:53:23Z

The committers listed above are authorized under a signed CLA.

✅ login: amarflybot / name: Amarendra Kumar (937a132, e1c0c42, 66daefb, 36b1d84, 01bb99f, eb10a2e, 7fc8884, 5cd7605)

knative-prow · 2024-12-09T13:53:29Z

Hi @amarflybot. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-12-09T13:57:51Z

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.52%. Comparing base (2d5a1e9) to head (01bb99f).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/apis/serving/fieldmask.go	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15648      +/-   ##
==========================================
+ Coverage   83.51%   83.52%   +0.01%     
==========================================
  Files         219      219              
  Lines       17427    17432       +5     
==========================================
+ Hits        14554    14560       +6     
+ Misses       2502     2499       -3     
- Partials      371      373       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skonto · 2024-12-09T14:38:21Z

--- a/config/core/300-resources/configuration.yaml +++ b/config/core/300-resources/configuration.yaml @@ -1582,4 +1582,4 @@ spec: ObservedGeneration is the 'Generation' of the Service that was last processed by the controller. type: integer - format: int64 \ No newline at end of file + format: int64

This needs fix.

skonto · 2024-12-09T14:38:25Z

/ok-to-test

skonto · 2024-12-09T14:39:36Z

hack/schemapatch-config.yaml

-  # Part of a feature flag - so we want to omit the schema and preserve unknown fields
-  - kubebuilder:validation:DropProperties
-  - kubebuilder:pruning:PreserveUnknownFields
+    # Part of a feature flag - so we want to omit the schema and preserve unknown fields


Could you remove additional space?

amarflybot · 2024-12-09T15:39:15Z

--- a/config/core/300-resources/configuration.yaml +++ b/config/core/300-resources/configuration.yaml @@ -1582,4 +1582,4 @@ spec: ObservedGeneration is the 'Generation' of the Service that was last processed by the controller. type: integer - format: int64 \ No newline at end of file + format: int64

This needs fix.

Fixed

skonto · 2024-12-09T15:43:04Z

config/core/300-resources/revision.yaml

-    kind: Revision
-    plural: revisions
-    singular: revision
+    kind: Service


This is the revision file this should not be changed.

skonto · 2024-12-09T15:43:33Z

config/core/300-resources/service.yaml

@@ -1728,4 +1732,4 @@ spec:
                  description: |-
                    URL holds the url that will distribute traffic over the provided traffic targets.
                    It generally has the form http[s]://{route-name}.{route-namespace}.{cluster-level-suffix}
-                  type: string
+                  type: string


A new line is missing.

amarflybot · 2024-12-09T17:10:36Z

/retest

skonto · 2024-12-10T11:34:30Z

@amarflybot could you update the description and add release notes. Also we need a follow up PR at the knative/docs repo to document this addition.

amarflybot · 2024-12-10T11:41:42Z

@amarflybot could you update the description and add release notes.

I have added. Will that do ?

skonto · 2024-12-10T11:42:01Z

/lgtm
/approve

/hold for @dprotaso for any additional comments.

amarflybot · 2024-12-10T19:04:08Z

/retest

amarflybot · 2024-12-10T20:07:54Z

/retest

skonto · 2024-12-13T08:40:17Z

/lgtm
/approve

skonto · 2024-12-13T08:48:29Z

/unhold

skonto · 2024-12-16T08:51:46Z

@dprotaso hi, gentle ping.

dprotaso

one minor thing for feedback

pkg/apis/serving/k8s_validation.go

dprotaso · 2025-01-06T17:38:14Z

/lgtm
/approve

knative-prow · 2025-01-06T17:38:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amarflybot, dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dprotaso,skonto]
~~pkg/apis/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso · 2025-01-06T17:38:30Z

thanks for the changes @amarflybot

dprotaso · 2025-01-06T17:57:53Z

/retest

amarflybot · 2025-01-06T18:10:24Z

/retest

vthurimella · 2025-01-06T20:34:29Z

Adding a hostPath to a serving.knative.dev/v1 Service will fail the validateVolume with this change. I think serving/pkg/apis/serving/k8s_validation.go needs to be updated as well to be the following

func validateVolume(ctx context.Context, volume corev1.Volume) *apis.FieldError {
	features := config.FromContextOrDefaults(ctx).Features
	errs := validatePersistentVolumeClaims(volume.VolumeSource, features)
	if volume.EmptyDir != nil && features.PodSpecVolumesEmptyDir != config.Enabled {
		errs = errs.Also(&apis.FieldError{Message: fmt.Sprintf("EmptyDir volume support is disabled, "+
			"but found EmptyDir volume %s", volume.Name)})
	}
	errs = errs.Also(apis.CheckDisallowedFields(volume, *VolumeMask(ctx, &volume)))
	if volume.Name == "" {
		errs = apis.ErrMissingField("name")
	} else if len(validation.IsDNS1123Label(volume.Name)) != 0 {
		errs = apis.ErrInvalidValue(volume.Name, "name")
	}
	vs := volume.VolumeSource
	errs = errs.Also(apis.CheckDisallowedFields(vs, *VolumeSourceMask(ctx, &vs)))
	var specified []string
	if vs.Secret != nil {
		specified = append(specified, "secret")
		for i, item := range vs.Secret.Items {
			errs = errs.Also(validateKeyToPath(item).ViaFieldIndex("items", i))
		}
	}
	if vs.ConfigMap != nil {
		specified = append(specified, "configMap")
		for i, item := range vs.ConfigMap.Items {
			errs = errs.Also(validateKeyToPath(item).ViaFieldIndex("items", i))
		}
	}
	if vs.Projected != nil {
		specified = append(specified, "projected")
		for i, proj := range vs.Projected.Sources {
			errs = errs.Also(validateProjectedVolumeSource(proj).ViaFieldIndex("projected", i))
		}
	}
	if vs.EmptyDir != nil {
		specified = append(specified, "emptyDir")
		errs = errs.Also(validateEmptyDirFields(vs.EmptyDir).ViaField("emptyDir"))
	}

	if vs.PersistentVolumeClaim != nil {
		specified = append(specified, "persistentVolumeClaim")
	}

	// Add hostPath to the list of specified volumes if it is enabled.
	if vs.HostPath != nil {
		specified = append(specified, "hostPath")
	}

	if len(specified) == 0 {
		fieldPaths := []string{"secret", "configMap", "projected"}
		cfg := config.FromContextOrDefaults(ctx)
		if cfg.Features.PodSpecVolumesEmptyDir == config.Enabled {
			fieldPaths = append(fieldPaths, "emptyDir")
		}
		if cfg.Features.PodSpecPersistentVolumeClaim == config.Enabled {
			fieldPaths = append(fieldPaths, "persistentVolumeClaim")
		}

		// Add hostPath to the list of specified volumes if it is enabled.
		if cfg.Features.PodSpecVolumesHostPath == config.Enabled {
			fieldPaths = append(fieldPaths, "hostPath")
		}
		errs = errs.Also(apis.ErrMissingOneOf(fieldPaths...))
	} else if len(specified) > 1 {
		errs = errs.Also(apis.ErrMultipleOneOf(specified...))
	}

	return errs
}

dprotaso · 2025-01-06T21:03:37Z

@vthurimella can you make a PR - i can't tell what the diff is from your code block

vthurimella · 2025-01-06T21:13:01Z

I created a PR here vthurimella#1

dprotaso · 2025-01-06T21:19:23Z

Can you make the PR against this repo?

Ideally, add a unit test that demonstrates the failure you describe along with your fix.

cheers

vthurimella · 2025-01-06T22:13:48Z

Can you make the PR against this repo?

Here is my PR: #15669

Ideally, add a unit test that demonstrates the failure you describe along with your fix.

I included some unit tests

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2024

knative-prow bot requested review from ReToCode and skonto December 9, 2024 13:53

amarflybot mentioned this pull request Dec 9, 2024

Support volume type "hostPath" for volume mounting #15546

Closed

15546: Add support for hostPath

e1c0c42

amarflybot force-pushed the feature/add_hostPath branch from a821b44 to e1c0c42 Compare December 9, 2024 14:06

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2024

skonto reviewed Dec 9, 2024

View reviewed changes

15546: Fix additional Space and eof

937a132

skonto reviewed Dec 9, 2024

View reviewed changes

amarflybot added 3 commits December 9, 2024 21:16

Fix eof

36b1d84

update for EOF

eb10a2e

revert mess up

66daefb

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2024

remove white spaces

7fc8884

skonto added the kind/enhancement label Dec 10, 2024

skonto changed the title ~~15546: Add support for hostPath~~ Add support for hostPath Dec 10, 2024

added Comment

5cd7605

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024

dprotaso reviewed Dec 30, 2024

View reviewed changes

pkg/apis/serving/k8s_validation.go Outdated Show resolved Hide resolved

remove extra validations as its there in K8

01bb99f

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2025

knative-prow bot assigned dprotaso Jan 6, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025

knative-prow bot merged commit 0d589da into knative:main Jan 6, 2025
68 checks passed

vthurimella mentioned this pull request Jan 6, 2025

Update volume validation to include hostPath #15669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for hostPath #15648

Add support for hostPath #15648

amarflybot commented Dec 9, 2024 •

edited by skonto

Loading

linux-foundation-easycla bot commented Dec 9, 2024 •

edited

Loading

knative-prow bot commented Dec 9, 2024

codecov bot commented Dec 9, 2024 •

edited

Loading

skonto commented Dec 9, 2024

skonto commented Dec 9, 2024

skonto Dec 9, 2024

amarflybot Dec 9, 2024

amarflybot commented Dec 9, 2024

skonto Dec 9, 2024

skonto Dec 9, 2024

amarflybot commented Dec 9, 2024

skonto commented Dec 10, 2024 •

edited

Loading

amarflybot commented Dec 10, 2024

skonto commented Dec 10, 2024 •

edited

Loading

amarflybot commented Dec 10, 2024

amarflybot commented Dec 10, 2024

skonto commented Dec 13, 2024

skonto commented Dec 13, 2024

skonto commented Dec 16, 2024

dprotaso left a comment

dprotaso commented Jan 6, 2025

knative-prow bot commented Jan 6, 2025

dprotaso commented Jan 6, 2025

dprotaso commented Jan 6, 2025

amarflybot commented Jan 6, 2025

vthurimella commented Jan 6, 2025 •

edited

Loading

dprotaso commented Jan 6, 2025

vthurimella commented Jan 6, 2025

dprotaso commented Jan 6, 2025

vthurimella commented Jan 6, 2025

Add support for hostPath #15648

Add support for hostPath #15648

Conversation

amarflybot commented Dec 9, 2024 • edited by skonto Loading

Description

Proposed Changes

linux-foundation-easycla bot commented Dec 9, 2024 • edited Loading

knative-prow bot commented Dec 9, 2024

codecov bot commented Dec 9, 2024 • edited Loading

Codecov Report

skonto commented Dec 9, 2024

skonto commented Dec 9, 2024

skonto Dec 9, 2024

Choose a reason for hiding this comment

amarflybot Dec 9, 2024

Choose a reason for hiding this comment

amarflybot commented Dec 9, 2024

skonto Dec 9, 2024

Choose a reason for hiding this comment

skonto Dec 9, 2024

Choose a reason for hiding this comment

amarflybot commented Dec 9, 2024

skonto commented Dec 10, 2024 • edited Loading

amarflybot commented Dec 10, 2024

skonto commented Dec 10, 2024 • edited Loading

amarflybot commented Dec 10, 2024

amarflybot commented Dec 10, 2024

skonto commented Dec 13, 2024

skonto commented Dec 13, 2024

skonto commented Dec 16, 2024

dprotaso left a comment

Choose a reason for hiding this comment

dprotaso commented Jan 6, 2025

knative-prow bot commented Jan 6, 2025

dprotaso commented Jan 6, 2025

dprotaso commented Jan 6, 2025

amarflybot commented Jan 6, 2025

vthurimella commented Jan 6, 2025 • edited Loading

dprotaso commented Jan 6, 2025

vthurimella commented Jan 6, 2025

dprotaso commented Jan 6, 2025

vthurimella commented Jan 6, 2025

amarflybot commented Dec 9, 2024 •

edited by skonto

Loading

linux-foundation-easycla bot commented Dec 9, 2024 •

edited

Loading

codecov bot commented Dec 9, 2024 •

edited

Loading

skonto commented Dec 10, 2024 •

edited

Loading

skonto commented Dec 10, 2024 •

edited

Loading

vthurimella commented Jan 6, 2025 •

edited

Loading