Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] TEST-ONLY change net-contour image to cors changes only #15231

Closed
wants to merge 9 commits into from
3 changes: 1 addition & 2 deletions test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
# project $PROJECT_ID, start knative in it, run the tests and delete the
# cluster.

source $(dirname $0)/e2e-common.sh

Check failure on line 28 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:28:-source $(dirname $0)/e2e-common.sh test/e2e-tests.sh:28:+source $(dirname "$0")/e2e-common.sh

# Script entry point.
initialize --num-nodes=4 --enable-ha --cluster-version=1.28 "$@"
Expand Down Expand Up @@ -54,7 +54,7 @@
kubectl apply -f "${E2E_YAML_DIR}"/test/config/externaldomaintls/certmanager/caissuer/
add_trap "kubectl delete -f ${E2E_YAML_DIR}/test/config/externaldomaintls/certmanager/caissuer/ --ignore-not-found" SIGKILL SIGTERM SIGQUIT
# we need to restart the pod in order to start the net-certmanager-controller
restart_pod ${SYSTEM_NAMESPACE} "app=controller"

Check failure on line 57 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:57:- restart_pod ${SYSTEM_NAMESPACE} "app=controller" test/e2e-tests.sh:57:+ restart_pod "${SYSTEM_NAMESPACE}" "app=controller"
fi

if (( MESH )); then
Expand All @@ -65,33 +65,32 @@
GO_TEST_FLAGS+=" -short"
fi


go_test_e2e -timeout=30m \
${GO_TEST_FLAGS} \

Check failure on line 69 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:69:- ${GO_TEST_FLAGS} \ test/e2e-tests.sh:69:+ "${GO_TEST_FLAGS}" \
./test/conformance/api/... \
./test/conformance/runtime/... \
./test/e2e \
${E2E_TEST_FLAGS} || failed=1

Check failure on line 73 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:73:- ${E2E_TEST_FLAGS} || failed=1 test/e2e-tests.sh:73:+ "${E2E_TEST_FLAGS}" || failed=1

toggle_feature tag-header-based-routing Enabled
go_test_e2e -timeout=2m ./test/e2e/tagheader ${E2E_TEST_FLAGS} || failed=1

Check failure on line 76 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:76:-go_test_e2e -timeout=2m ./test/e2e/tagheader ${E2E_TEST_FLAGS} || failed=1 test/e2e-tests.sh:76:+go_test_e2e -timeout=2m ./test/e2e/tagheader "${E2E_TEST_FLAGS}" || failed=1
toggle_feature tag-header-based-routing Disabled

toggle_feature allow-zero-initial-scale true config-autoscaler || fail_test
go_test_e2e -timeout=2m ./test/e2e/initscale ${E2E_TEST_FLAGS} || failed=1

Check failure on line 80 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:80:-go_test_e2e -timeout=2m ./test/e2e/initscale ${E2E_TEST_FLAGS} || failed=1 test/e2e-tests.sh:80:+go_test_e2e -timeout=2m ./test/e2e/initscale "${E2E_TEST_FLAGS}" || failed=1
toggle_feature allow-zero-initial-scale false config-autoscaler || fail_test

go_test_e2e -timeout=2m ./test/e2e/domainmapping ${E2E_TEST_FLAGS} || failed=1

Check failure on line 83 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:83:-go_test_e2e -timeout=2m ./test/e2e/domainmapping ${E2E_TEST_FLAGS} || failed=1 test/e2e-tests.sh:83:+go_test_e2e -timeout=2m ./test/e2e/domainmapping "${E2E_TEST_FLAGS}" || failed=1

toggle_feature cluster-local-domain-tls enabled config-network || fail_test
go_test_e2e -timeout=2m ./test/e2e/clusterlocaldomaintls ${E2E_TEST_FLAGS} || failed=1

Check failure on line 86 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:86:-go_test_e2e -timeout=2m ./test/e2e/clusterlocaldomaintls ${E2E_TEST_FLAGS} || failed=1 test/e2e-tests.sh:86:+go_test_e2e -timeout=2m ./test/e2e/clusterlocaldomaintls "${E2E_TEST_FLAGS}" || failed=1
toggle_feature cluster-local-domain-tls disabled config-network || fail_test

toggle_feature system-internal-tls enabled config-network || fail_test
toggle_feature "logging.enable-request-log" true config-observability || fail_test
toggle_feature "logging.request-log-template" "TLS: {{.Request.TLS}}" config-observability || fail_test
# with current implementation, Activator must be restarted when configuring system-internal-tls. See https://github.com/knative/serving/issues/13754
restart_pod ${SYSTEM_NAMESPACE} "app=activator"

Check failure on line 93 in test/e2e-tests.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell

[shellcheck (suggestion)] reported by reviewdog 🐶 Raw Output: test/e2e-tests.sh:93:-restart_pod ${SYSTEM_NAMESPACE} "app=activator" test/e2e-tests.sh:93:+restart_pod "${SYSTEM_NAMESPACE}" "app=activator"

# we need to restart the pod in order to start the net-certmanager-controller
if (( ! HTTPS )); then
Expand Down Expand Up @@ -119,7 +118,7 @@
if [[ "${INGRESS_CLASS}" == *"contour"* ]]; then
toggle_feature cors-policy "allowOrigin:\n - '*'\nallowMethods:\n - GET\n - OPTIONS\n" config-contour || fail_test
go_test_e2e -timeout=2m ./test/e2e/corspolicy ${E2E_TEST_FLAGS} || failed=1
toggle_feature cors-policy "" config-contour || fail_test
kubectl patch cm config-contour -n "${SYSTEM_NAMESPACE}" --type=json -p '[{"op": "remove", "path": "/data/cors-policy"}]'
fi

# Run scale tests.
Expand Down
Loading