Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Include a test that reproduces issue #13677 #14909

Closed
wants to merge 4 commits into from
Closed

[wip] Include a test that reproduces issue #13677 #14909

wants to merge 4 commits into from

Conversation

dprotaso
Copy link
Member

Part of #13677

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Feb 16, 2024
@dprotaso
Copy link
Member Author

dprotaso commented Feb 16, 2024 •
edited
Loading

/hold

I didn't skip the test so I'm expecting it to fail - will update after I confirm the failure happens in CI (I tested locally)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2024
@dprotaso dprotaso requested a review from izabelacg February 16, 2024 16:16
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aa8043) 85.74% compared to head (dd77d91) 85.75%.
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14909      +/-   ##
==========================================
+ Coverage   85.74%   85.75%   +0.01%     
==========================================
  Files         198      198              
  Lines       15153    15153              
==========================================
+ Hits        12993    12995       +2     
+ Misses       1833     1832       -1     
+ Partials      327      326       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/retest istio-latest-no-mesh_serving_main

@knative knative deleted a comment from knative-prow bot Feb 16, 2024
@dprotaso
Copy link
Member Author

hmm.. fails when it's just running by itself

/test istio-latest-no-mesh_serving_main

@dprotaso dprotaso removed the request for review from izabelacg February 17, 2024 01:50
@dprotaso dprotaso changed the title Include a test that reproduces issue #13677 [wip] Include a test that reproduces issue #13677 Feb 17, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2024
@dprotaso
Copy link
Member Author

/retest

@dprotaso dprotaso force-pushed the test-for-13677 branch 4 times, most recently from 1b00dcf to e3fdd93 Compare February 18, 2024 17:53
@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

1 similar comment
@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

2 similar comments
@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso
Copy link
Member Author

/test istio-latest-no-mesh_serving_main

@dprotaso dprotaso closed this Feb 21, 2024
@dprotaso dprotaso mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dprotaso