Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-contour nightly #14560

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Oct 24, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-contour.yaml contour.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-contour/latest/$x > ${GITHUB_WORKSPACE}/./third_party/contour-latest/$x
done

Details:

bumping knative.dev/net-contour 6a7283f...e6d90b9:
  > e6d90b9 bump contour to v1.26.1 (# 991)
  > 17e09ee upgrade to latest dependencies (# 990)

@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from fc57030 to 11bb083 Compare October 24, 2023 11:05
@knative-prow knative-prow bot requested a review from a team October 24, 2023 11:05
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/networking labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f5fd3c) 86.01% compared to head (52e4fb5) 85.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14560      +/-   ##
==========================================
- Coverage   86.01%   85.98%   -0.04%     
==========================================
  Files         197      197              
  Lines       14916    14916              
==========================================
- Hits        12830    12825       -5     
- Misses       1776     1779       +3     
- Partials      310      312       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
bumping knative.dev/net-contour 6a7283f...e6d90b9:
  > e6d90b9 bump contour to v1.26.1 (# 991)
  > 17e09ee upgrade to latest dependencies (# 990)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from 11bb083 to 52e4fb5 Compare October 25, 2023 11:05
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@knative-prow knative-prow bot merged commit 2f91f92 into knative:main Oct 25, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants