Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run internal encryption tests with contour #14521

Merged

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Oct 13, 2023

Fixes #

Proposed Changes

Release Note

N/A

@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Oct 13, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2023
@KauzClay
Copy link
Contributor Author

@ReToCode @nak3 @dprotaso

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6703812) 86.08% compared to head (9a09791) 86.12%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14521      +/-   ##
==========================================
+ Coverage   86.08%   86.12%   +0.04%     
==========================================
  Files         196      196              
  Lines       14887    14887              
==========================================
+ Hits        12815    12822       +7     
+ Misses       1761     1756       -5     
+ Partials      311      309       -2     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KauzClay
Copy link
Contributor Author

/test istio-ambient

@knative-prow
Copy link

knative-prow bot commented Oct 13, 2023

@KauzClay: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-tests
  • /test contour-latest
  • /test contour-tls
  • /test gateway-api-latest
  • /test istio-latest-no-mesh
  • /test istio-latest-no-mesh-tls
  • /test kourier-stable
  • /test kourier-stable-tls
  • /test unit-tests
  • /test upgrade-tests

The following commands are available to trigger optional jobs:

  • /test https
  • /test istio-latest-mesh
  • /test istio-latest-mesh-short
  • /test istio-latest-mesh-tls
  • /test performance-tests

Use /test all to run the following jobs that were automatically triggered:

  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • unit-tests_serving_main
  • upgrade-tests_serving_main

In response to this:

/test istio-ambient

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor

nak3 commented Oct 14, 2023

/test contour-latest

@nak3
Copy link
Contributor

nak3 commented Oct 14, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KauzClay, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2023
@knative-prow knative-prow bot merged commit 6a21d8a into knative:main Oct 14, 2023
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants