Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s min and deps to 1.30 #3124

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 17, 2024

Changes

  • We need 1.30 at the API side for 1.17, see here.
  • Set min to 1.30 as 1.29 is in maintenance mode.

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo December 17, 2024 15:34
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024
@skonto skonto changed the title Update k8s min and deps [wip] Update k8s min and deps Dec 17, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@skonto skonto changed the title [wip] Update k8s min and deps [wip] Update k8s min to 1.30.0 and deps Dec 18, 2024
@skonto skonto requested review from dprotaso and ReToCode and removed request for Leo6Leo and Cali0707 December 18, 2024 08:44
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (f3ab560) to head (17feba1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   78.29%   78.32%   +0.02%     
==========================================
  Files         191      191              
  Lines       11186    11186              
==========================================
+ Hits         8758     8761       +3     
+ Misses       2162     2160       -2     
+ Partials      266      265       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Dec 18, 2024

Downstream tests fail due to:

  go: added sigs.k8s.io/yaml v1.4.0
  Error: /home/runner/work/pkg/pkg/downstream/vendor/k8s.io/api/core/v1/doc.go:21:1: missing argument "" (at <input>)
  Error: /home/runner/work/pkg/pkg/downstream/vendor/k8s.io/api/core/v1/doc.go:21:1: missing argument "" (at <input>)
  k8s.io/api/core/v1:-: unknown type k8s.io/api/core/v1.PodSpec

In that file there is:

...
// +groupName=

We need to patch https://github.com/dprotaso/controller-tools/commits/knative/ to ignore empty values as when I set +groupName="" locally it run fine.

cc @dprotaso

@skonto skonto changed the title [wip] Update k8s min to 1.30.0 and deps Update k8s min to 1.29.0 and deps to 1.30 Dec 19, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@skonto skonto changed the title Update k8s min to 1.29.0 and deps to 1.30 Update k8s min and deps to 1.30 Dec 20, 2024
@dprotaso
Copy link
Member

knative/serving#15664 should unblock this

@skonto
Copy link
Contributor Author

skonto commented Jan 9, 2025

/retest

@skonto
Copy link
Contributor Author

skonto commented Jan 9, 2025

networking still suffers I will need to bump the version of the controller runtime tools there and try again:

Error: /home/runner/work/pkg/pkg/downstream/vendor/k8s.io/api/core/v1/doc.go:21:1: missing argument "" (at )
Error: /home/runner/work/pkg/pkg/downstream/vendor/k8s.io/api/core/v1/doc.go:21:1: missing argument "" (at )
k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ConditionStatus
k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ConditionStatus
k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ObjectReference
k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ObjectReference
knative.dev/pkg/apis:-: unable to locate schema for type "k8s.io/api/core/v1".ConditionStatus
knative.dev/networking/pkg/apis/networking/v1alpha1:-: unable to locate schema for type "k8s.io/api/core/v1".ObjectReference
Error: not all generators ran successfully
run controller-gen schemapatch:manifests=config/,generateEmbeddedObjectMeta=false output:dir=config paths=./pkg/apis/... -w to see all available markers, or controller-gen schemapatch:manifests=config/,generateEmbeddedObjectMeta=false output:dir=config paths=./pkg/apis/... -h for usage
exit status 1

@skonto
Copy link
Contributor Author

skonto commented Jan 9, 2025

I guess we have golang style stuff to fix in a separate PR.

@skonto
Copy link
Contributor Author

skonto commented Jan 9, 2025

Eventing failure seems irrelevant.

ok knative.dev/eventing/pkg/apis/sugar 1.018s
--- FAIL: TestSetupOIDCServiceAccount (0.06s)
logger.go:146: 2025-01-09T14:02:38.787Z DEBUG auth/serviceaccount.go:96 Creating OIDC service account {"error": "serviceaccount "my-trigger-oidc-eventing.knative.dev-trigger" not found"}
logger.go:146: 2025-01-09T14:02:38.800Z DEBUG auth/serviceaccount.go:137 OIDC Service account exists and has correct owner (my-trigger/my-namespace). Deleting OIDC service account
serviceaccount_test.go:249: DeleteOIDCServiceAccountIfExists failed to delete the serviceAccount: &ServiceAccount{ObjectMeta:{ 0 0001-01-01 00:00:00 +0000 UTC map[] map[] [] [] []},Secrets:[]ObjectReference{},ImagePullSecrets:[]LocalObjectReference{},AutomountServiceAccountToken:nil,}
--- FAIL: TestDeleteOIDCServiceAccountIfExists (0.05s)
logger.go:146: 2025-01-09T14:02:38.857Z DEBUG auth/serviceaccount.go:137 OIDC Service account exists and has correct owner (my-broker-unique/my-namespace). Deleting OIDC service account
serviceaccount_test.go:325: DeleteOIDCServiceAccountIfExists failed to delete the serviceAccount: &ServiceAccount{ObjectMeta:{ 0 0001-01-01 00:00:00 +0000 UTC map[] map[] [] [] []},Secrets:[]ObjectReference{},ImagePullSecrets:[]LocalObjectReference{},AutomountServiceAccountToken:nil,}
FAIL

@skonto
Copy link
Contributor Author

skonto commented Jan 9, 2025

/retest

@skonto
Copy link
Contributor Author

skonto commented Jan 9, 2025

@pierDipi is the downstream Eventing failure a known one?

--- FAIL: TestSetupOIDCServiceAccount (0.07s)
logger.go:146: 2025-01-09T15:19:05.069Z DEBUG auth/serviceaccount.go:96 Creating OIDC service account {"error": "serviceaccount "my-trigger-oidc-eventing.knative.dev-trigger" not found"}
logger.go:146: 2025-01-09T15:19:05.084Z DEBUG auth/serviceaccount.go:137 OIDC Service account exists and has correct owner (my-trigger/my-namespace). Deleting OIDC service account
serviceaccount_test.go:249: DeleteOIDCServiceAccountIfExists failed to delete the serviceAccount: &ServiceAccount{ObjectMeta:{ 0 0001-01-01 00:00:00 +0000 UTC map[] map[] [] [] []},Secrets:[]ObjectReference{},ImagePullSecrets:[]LocalObjectReference{},AutomountServiceAccountToken:nil,}
--- FAIL: TestDeleteOIDCServiceAccountIfExists (0.03s)
logger.go:146: 2025-01-09T15:19:05.129Z DEBUG auth/serviceaccount.go:137 OIDC Service account exists and has correct owner (my-broker-unique/my-namespace). Deleting OIDC service account
serviceaccount_test.go:325: DeleteOIDCServiceAccountIfExists failed to delete the serviceAccount: &ServiceAccount{ObjectMeta:{ 0 0001-01-01 00:00:00 +0000 UTC map[] map[] [] [] []},Secrets:[]ObjectReference{},ImagePullSecrets:[]LocalObjectReference{},AutomountServiceAccountToken:nil,}
FAIL

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2025

/lgtm
/approve

can do lint changes in a follow up

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
Copy link

knative-prow bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 23c15c0 into knative:main Jan 9, 2025
69 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants