Enable Go ARM64 buildpack #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added adjustments that enable Go buildpack build on arm64 machines. Paketo buildpack do not distribute serveral buildpacks in arm64 variant, so we need to build them. Namely we need to build: go go-dist go-build go-mod-vendor git Signed-off-by: Matej Vašek <[email protected]>
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/L
matejvasek
requested review from
matzew,
gauron99 and
lkingland
and removed request for
dsimansk and
jrangelramos
|
PTAL @lkingland @gauron99 @matzew |
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
+ Coverage 64.13% 65.42% +1.28%
==========================================
Files 130 130
Lines 15518 15518
==========================================
+ Hits 9953 10152 +199
+ Misses 4625 4389 -236
- Partials 940 977 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lkingland
approved these changes
Jan 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added adjustments that enable Go buildpack build on arm64 machines. Paketo buildpack do not distribute serveral buildpacks in arm64 variant, so we need to build them.
Namely we need to build:
fixes #2623