Fix some linter errors in integration tests #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
requested review from
lkingland
and removed request for
dsimansk and
nainaz
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/M
Signed-off-by: Matej Vašek <[email protected]>
matejvasek
force-pushed
the
fix-some-linter-errs-2
branch
from
3211879 to
b1acfa2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
===========================================
+ Coverage 50.93% 65.42% +14.48%
===========================================
Files 130 130
Lines 15518 15518
===========================================
+ Hits 7904 10152 +2248
+ Misses 6898 4389 -2509
- Partials 716 977 +261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matejvasek
commented
Dec 2, 2024
Signed-off-by: Matej Vašek <[email protected]>
|
PTAL @gauron99 @lkingland @matzew |
|
/lgtm |
knative-prow
bot
added
the
do-not-merge/hold
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes