Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pack/s2i/docker deps #2604

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Update pack/s2i/docker deps #2604

merged 1 commit into from
Dec 2, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Nov 29, 2024 •
edited
Loading

Changes

  • 🧹 update buildpack dependency
  • 🧹 update source-to-image dependency
  • 🧹 update required Go version to 1.23

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 29, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from nainaz and rhuss November 29, 2024 16:31
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.41%. Comparing base (3d19d9b) to head (cef29bb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
+ Coverage   64.14%   65.41%   +1.27%     
==========================================
  Files         130      130              
  Lines       15516    15516              
==========================================
+ Hits         9952    10150     +198     
+ Misses       4624     4389     -235     
- Partials      940      977      +37
Flag Coverage Δ
e2e-test 35.79% <ø> (-0.03%) ⬇️
e2e-test-oncluster 32.81% <ø> (-0.08%) ⬇️
e2e-test-oncluster-runtime 28.66% <ø> (?)
e2e-test-runtime-go 26.45% <ø> (?)
e2e-test-runtime-node 25.85% <ø> (?)
e2e-test-runtime-python 25.85% <ø> (?)
e2e-test-runtime-quarkus 26.00% <ø> (?)
e2e-test-runtime-rust 24.95% <ø> (?)
e2e-test-runtime-springboot 24.99% <ø> (?)
e2e-test-runtime-typescript 25.96% <ø> (?)
integration-tests 51.97% <ø> (+2.25%) ⬆️
unit-tests 50.92% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for rhuss and nainaz November 29, 2024 17:18
@matejvasek
Copy link
Contributor Author

I am afraid this dep bump would require knative-wide Go update to 1.23.

matzew
matzew reviewed Dec 2, 2024
View reviewed changes
go.mod
@@ -1,6 +1,6 @@
module knative.dev/func

go 1.22.7
go 1.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check w/ the rest of upstream, regarding this bump?

CC @dsimansk

Copy link
Contributor

@dsimansk dsimansk Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, we would eventually move to toolchain 1.23.z regardless that's CI infra, pipelines, gh actions.

Personally I don't like go.mod minVersion bumps unless warranted by other dependencies or specific go feature from newer version.

Copy link
Contributor Author

@matejvasek matejvasek Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest buildpack requires go1.23. Also if I just wanted to update source-to-image we are at the same place: the latest source-to-image requires docker v27 and only latest buildpacks work with that.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@cardil cardil mentioned this pull request Dec 2, 2024
Merged
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@matejvasek
Update deps
cef29bb 
Update pack
Update source-to-image
Update required Go version

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek matejvasek requested a review from dsimansk December 2, 2024 15:31
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland @dsimansk

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@gauron99
Copy link
Contributor

gauron99 commented Dec 2, 2024

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@knative-prow knative-prow bot merged commit 0e150e0 into knative:main Dec 2, 2024
39 checks passed
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@gauron99 gauron99 gauron99 approved these changes

@lkingland lkingland Awaiting requested review from lkingland

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@gauron99 gauron99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matejvasek @gauron99 @matzew @dsimansk @knative-prow-robot