Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding e2e test for config volumes EmptyDir and PersistentVolumeClaim #2078

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🎁 Adding e2e test for PersistenceVolumeClaim and EmptyDir
    /kind

/kind enhancement

Copy link

knative-prow bot commented Nov 9, 2023

@jrangelramos: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🎁 Adding e2e test for PersistenceVolumeClaim and EmptyDir
    /kind

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from dsimansk and nainaz November 9, 2023 17:17
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7af58b5) 63.50% compared to head (1af7f4d) 64.83%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
+ Coverage   63.50%   64.83%   +1.33%     
==========================================
  Files         108      108              
  Lines       13865    13865              
==========================================
+ Hits         8805     8990     +185     
+ Misses       4191     3982     -209     
- Partials      869      893      +24     
Flag Coverage Δ
e2e-test 36.67% <ø> (+0.39%) ⬆️
e2e-test-oncluster 30.57% <ø> (ø)
e2e-test-oncluster-runtime 26.83% <ø> (?)
e2e-test-runtime-go 25.57% <ø> (?)
e2e-test-runtime-node 26.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.57% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.82% <ø> (+2.06%) ⬆️
unit-tests-macos-latest 48.75% <ø> (ø)
unit-tests-ubuntu-latest 49.48% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.78% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
Copy link

knative-prow bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

@jrangelramos how big PVC do you request? Maybe it's too big for testing cluster?

@jrangelramos
Copy link
Contributor Author

@jrangelramos jrangelramos marked this pull request as draft November 14, 2023 17:48
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
@jrangelramos jrangelramos marked this pull request as ready for review November 16, 2023 19:11
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2023
@knative-prow knative-prow bot requested review from rhuss and vyasgun November 16, 2023 19:11
@lkingland
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@knative-prow knative-prow bot merged commit 6f0b90d into knative:main Nov 20, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants