-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding e2e test for config volumes EmptyDir and PersistentVolumeClaim #2078
Conversation
@jrangelramos: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
==========================================
+ Coverage 63.50% 64.83% +1.33%
==========================================
Files 108 108
Lines 13865 13865
==========================================
+ Hits 8805 8990 +185
+ Misses 4191 3982 -209
- Partials 869 893 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6134acf
to
1aaf49e
Compare
1aaf49e
to
11d4388
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jrangelramos how big PVC do you request? Maybe it's too big for testing cluster? |
@matejvasek should be small one.. 1Kb (I believe) .. check it out https://github.com/knative/func/pull/2078/files#diff-4ccb676e582b304e248178f82a6a0e5fcf4e7319a417a9cd16c893cae2b43201R220 |
11d4388
to
1af7f4d
Compare
/lgtm |
Changes
/kind
/kind enhancement