fix: release uses correct version tags #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XS
knative-prow
bot
added
the
approved
matejvasek
requested review from
cardil,
lance,
jrangelramos,
gauron99,
lkingland and
krsna-m
and removed request for
navidshaikh and
vyasgun
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
==========================================
+ Coverage 63.53% 64.47% +0.94%
==========================================
Files 108 108
Lines 13839 13839
==========================================
+ Hits 8792 8923 +131
+ Misses 4182 4026 -156
- Partials 865 890 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cardil
reviewed
Nov 6, 2023
Signed-off-by: Matej Vasek <[email protected]>
matejvasek
force-pushed
the
fix-release-envvars
branch
from
1b08a29 to
63408c1
Compare
knative-prow
bot
added
size/S
|
PTAL @jrangelramos @lkingland |
lkingland
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Thanks @matejvasek!
/hold ing for the requested review from Chris
lkingland
added
the
do-not-merge/hold
lkingland
reviewed
Nov 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.