Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify embedded templates #2050

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek matejvasek requested a review from lance October 24, 2023 19:01
@knative-prow
Copy link

knative-prow bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from gauron99 and vyasgun October 24, 2023 19:01
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@matejvasek matejvasek requested review from jrangelramos and lkingland and removed request for vyasgun October 24, 2023 19:01
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a2db8e) 63.64% compared to head (0b368a6) 64.64%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
+ Coverage   63.64%   64.64%   +1.00%     
==========================================
  Files         107      107              
  Lines       13700    13700              
==========================================
+ Hits         8720     8857     +137     
+ Misses       4125     3965     -160     
- Partials      855      878      +23     
Flag Coverage Δ
e2e-test 36.46% <ø> (ø)
e2e-test-oncluster 30.53% <ø> (ø)
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.56% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.74% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.92% <ø> (+2.08%) ⬆️
unit-tests-macos-latest 48.78% <ø> (ø)
unit-tests-ubuntu-latest 49.54% <ø> (+0.02%) ⬆️
unit-tests-windows-latest 48.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek changed the title test: do test embedded template test: verify embedded templates Oct 24, 2023
@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @gauron99 @lkingland

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@knative-prow knative-prow bot merged commit b1b329e into knative:main Oct 26, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants