Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add go setup as composite action #2031

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

dsimansk
Copy link
Contributor

Changes

  • chore: Add go setup as composite action

This is a very opinionated proposal. I can just sed all the version otherwise. :)

There are several go version matrix params, but specifying single value only. I wonder if something more centralized could be a bit easier to maintain.

/cc @lkingland @matejvasek

/kind

Fixes #

Release Note

NONE

@knative-prow
Copy link

knative-prow bot commented Oct 17, 2023

@dsimansk: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • chore: Add go setup as composite action

This is a very opinionated proposal. I can just sed all the version otherwise. :)

There are several go version matrix params, but specifying single value only. I wonder if something more centralized could be a bit easier to maintain.

/cc @lkingland @matejvasek

/kind

Fixes #

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
@dsimansk dsimansk force-pushed the pr/composite-go-version branch 2 times, most recently from f2122c5 to 0f8e5e6 Compare October 17, 2023 17:41
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3641bfe) 61.76% compared to head (48121af) 62.71%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
+ Coverage   61.76%   62.71%   +0.94%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8458     8587     +129     
+ Misses       4390     4235     -155     
- Partials      845      871      +26     
Flag Coverage Δ
e2e-test 36.46% <ø> (ø)
e2e-test-oncluster ?
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.59% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.42% <ø> (+2.12%) ⬆️
unit-tests-macos-latest 48.21% <ø> (+0.02%) ⬆️
unit-tests-ubuntu-latest 48.98% <ø> (ø)
unit-tests-windows-latest 48.26% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk dsimansk force-pushed the pr/composite-go-version branch from 0f8e5e6 to 48121af Compare October 18, 2023 18:23
@lkingland
Copy link
Member

Well I like it, and any attention paid to our tooling is appreciated

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4deb1ff into knative:main Oct 19, 2023
35 checks passed
@dsimansk dsimansk deleted the pr/composite-go-version branch October 19, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants