-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add go setup as composite action #2031
Conversation
@dsimansk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2122c5
to
0f8e5e6
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
==========================================
+ Coverage 61.76% 62.71% +0.94%
==========================================
Files 106 106
Lines 13693 13693
==========================================
+ Hits 8458 8587 +129
+ Misses 4390 4235 -155
- Partials 845 871 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0f8e5e6
to
48121af
Compare
Well I like it, and any attention paid to our tooling is appreciated /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This is a very opinionated proposal. I can just
sed
all the version otherwise. :)There are several go version matrix params, but specifying single value only. I wonder if something more centralized could be a bit easier to maintain.
/cc @lkingland @matejvasek
/kind
Fixes #
Release Note