Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue on error when one of runtimes fails #2008

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow
Copy link

knative-prow bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from navidshaikh and vyasgun October 6, 2023 18:12
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
@matejvasek matejvasek requested review from jrangelramos, gauron99 and lkingland and removed request for navidshaikh and vyasgun October 6, 2023 18:12
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9cf1ed7) 59.46% compared to head (ddbdad0) 62.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
+ Coverage   59.46%   62.76%   +3.30%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8143     8595     +452     
+ Misses       4724     4230     -494     
- Partials      826      868      +42     
Flag Coverage Δ
e2e-test 36.49% <ø> (+0.02%) ⬆️
e2e-test-oncluster 30.44% <ø> (-0.09%) ⬇️
e2e-test-oncluster-runtime 26.79% <ø> (?)
e2e-test-runtime-go 25.59% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.50% <ø> (?)
e2e-test-runtime-springboot 25.64% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.41% <ø> (?)
unit-tests-macos-latest 48.21% <ø> (ø)
unit-tests-ubuntu-latest 48.98% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.23% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

@lance please override "On Cluster RT Test (1.20.2, ubuntu-latest, pack)" and "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

@matejvasek matejvasek force-pushed the matejvasek/no-fast-fail branch from 2d65a20 to 99f0e22 Compare October 8, 2023 14:31
@matejvasek matejvasek force-pushed the matejvasek/no-fast-fail branch from 99f0e22 to ddbdad0 Compare October 9, 2023 13:38
@lance
Copy link
Member

lance commented Oct 9, 2023

/override "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

@knative-prow
Copy link

knative-prow bot commented Oct 9, 2023

@lance: Overrode contexts on behalf of lance: On Cluster RT Test (1.20.2, ubuntu-latest, s2i)

In response to this:

/override "On Cluster RT Test (1.20.2, ubuntu-latest, s2i)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @gauron99 @lkingland

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@knative-prow knative-prow bot merged commit 429d379 into main Oct 9, 2023
36 of 37 checks passed
@gauron99
Copy link
Contributor

gauron99 commented Oct 9, 2023

/lgtm

@dsimansk dsimansk deleted the matejvasek/no-fast-fail branch May 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants