Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for func subscribe for creating mutiple triggers, based on event filters #2001

Merged
merged 21 commits into from
Nov 6, 2023

misspell instruction

c30a5c4
Select commit
Loading
Failed to load commit list.
Merged

Adding support for func subscribe for creating mutiple triggers, based on event filters #2001

misspell instruction
c30a5c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2023 in 1s

64.47% (+0.85%) compared to d258a19

View this Pull Request on Codecov

64.47% (+0.85%) compared to d258a19

Details

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (d258a19) 63.62% compared to head (c30a5c4) 64.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   63.62%   64.47%   +0.85%     
==========================================
  Files         107      108       +1     
  Lines       13705    13839     +134     
==========================================
+ Hits         8720     8923     +203     
+ Misses       4129     4026     -103     
- Partials      856      890      +34     
Files Coverage Δ
cmd/root.go 81.46% <100.00%> (+0.08%) ⬆️
pkg/functions/function.go 85.85% <ø> (ø)
cmd/subscribe.go 80.00% <80.00%> (ø)
pkg/knative/deployer.go 61.09% <13.79%> (-3.69%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.