Adding initial doc for IntegrationSink #6163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow
bot
added
the
size/L
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
dsimansk
reviewed
Nov 26, 2024
| spec: | ||
| aws: | ||
| sqs: | ||
| arn: "arn:aws:s3:::my-queue" |
There was a problem hiding this comment.
Is it intentional with 3 colons s3:::my-queue?
There was a problem hiding this comment.
thats the arn 😅, @dsimansk
so, yes intentional
|
thats the arn 😅
Sent from Gmail Mobile
…On Tue 26. Nov 2024 at 11:37, David Simansky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/eventing/sinks/integration-sink/aws_sqs.md
<#6163 (comment)>:
> + ```
+
+## AWS SQS Sink Example
+
+Below is an `IntegrationSink` to send data to AWS SQS:
+
+ ```yaml
+ apiVersion: Sinks.knative.dev/v1alpha1
+ kind: IntegrationSink
+ metadata:
+ name: integration-sink-aws-sqs
+ namespace: knative-samples
+ spec:
+ aws:
+ sqs:
+ arn: "arn:aws:s3:::my-queue"
Is it intentional with 3 colons s3:::my-queue?
—
Reply to this email directly, view it on GitHub
<#6163 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTSD4SZ2474F7BU3XZD2CRFPLAVCNFSM6AAAAABSQCQQS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRRGA3DQNRUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Cali0707
reviewed
Nov 26, 2024
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
Cali0707
approved these changes
Nov 26, 2024
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes