Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] add deprecation notices for net-http01 #5762

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[release-1.12] add deprecation notices for net-http01 #5762

merged 1 commit into from
Nov 21, 2023

Conversation

dprotaso
Copy link
Member

@knative-prow knative-prow bot requested review from matzew and pierDipi November 20, 2023 22:23
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2023
@dprotaso
Copy link
Member Author

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso mentioned this pull request Nov 20, 2023
Closed
14 tasks
@dprotaso dprotaso force-pushed the deprecate-net-http01 branch from 8927c9d to 3d71c2d Compare November 20, 2023 22:47
ReToCode
ReToCode approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ac2cda4 into knative:release-1.12 Nov 21, 2023
13 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #5763

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 21, 2023
Merged
@dprotaso dprotaso deleted the deprecate-net-http01 branch November 21, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@matzew matzew Awaiting requested review from matzew

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @knative-prow-robot @ReToCode