Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak Run:ai entry #1652

Merged
merged 1 commit into from
Dec 15, 2024
Merged

tweak Run:ai entry #1652

merged 1 commit into from
Dec 15, 2024

Conversation

dprotaso
Copy link
Member

Address feedback

#1649 (review)

Copy link

knative-prow bot commented Dec 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and salaboy December 15, 2024 22:15
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2024
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2024
@knative-prow knative-prow bot merged commit 2e43dbc into knative:main Dec 15, 2024
3 checks passed
@@ -31,7 +31,7 @@ If you would like to be included in this table, please open [an issue](https://g
| ManoMano* | | Development & Production | [link](https://www.manomano.es/) |
| Optum* | | Production | [link](https://optum.com/) |
| Red Hat | Red Hat OpenShift Serverless | Generally Available | [link](https://www.openshift.com/learn/topics/serverless) |
| Run:AI | Run:AI Platform | Production | [link](https://www.run.ai/platform) |
| Run:ai | Run:AI Platform | Production | [link](https://www.run.ai) |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but "Run:AI Platform" should also be changed to "Run:ai Platform". Thank you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops - I didn't push my latest changes. Let me do a follow up

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: #1653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants