Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --inject-broker flag from trigger cmds #1853

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Remove deprecated --inject-broker flag from trigger cmds #1853

merged 1 commit into from
Aug 23, 2023

Conversation

xiangpingjiang
Copy link
Contributor

@xiangpingjiang xiangpingjiang commented Aug 18, 2023 •
edited by dsimansk
Loading

Description

Changes

  • remove deprecated --inject-broker flag
  • remove related test

Reference

Fixes #1846

Release Note

Remove deprecated `--inject-broker` flag from `kn trigger` cmd group

@knative-prow
Copy link

knative-prow bot commented Aug 18, 2023

Welcome @xiangpingjiang! It looks like this is your first PR to knative/client 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 18, 2023

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot]
knative-prow bot reviewed Aug 18, 2023
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangpingjiang: 0 warnings.

In response to this:

Description

Changes

  • remove deprecated --inject-broker flag
  • remove related test

Reference

Fixes #1846

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (9676e46) 79.64% compared to head (0cf971a) 79.62%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   79.64%   79.62%   -0.02%     
==========================================
  Files         179      179              
  Lines       13938    13927      -11     
==========================================
- Hits        11101    11090      -11     
  Misses       2070     2070              
  Partials      767      767
Files Changed Coverage Δ
pkg/kn/commands/trigger/create.go 67.64% <ø> (-3.02%) ⬇️
pkg/kn/commands/trigger/update_flags.go 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk dsimansk added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 21, 2023
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2023
@dsimansk
Copy link
Contributor

The failing E2E are unrelated to this PR, see #1854.

@xiangpingjiang
Copy link
Contributor Author

The failing E2E are unrelated to this PR, see #1854.

@dsimansk

Thanks, I will try to fix it.

@xiangpingjiang
Copy link
Contributor Author

/retest

@xiangpingjiang
Copy link
Contributor Author

@dsimansk all tests passed, now can we merge this pr?

@dsimansk
Copy link
Contributor

dsimansk commented Aug 23, 2023 •
edited
Loading

@dsimansk all tests passed, now can we merge this pr?

Sure, and once again thanks for fixing the deprecated API on the way. Greatly appreciated!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@knative-prow knative-prow bot merged commit a9ee31f into knative:main Aug 23, 2023
17 checks passed
@xiangpingjiang xiangpingjiang deleted the cleanup branch September 11, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

@creydr creydr Awaiting requested review from creydr

@itsmurugappan itsmurugappan Awaiting requested review from itsmurugappan

@skonto skonto Awaiting requested review from skonto

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated --inject-broker flag from trigger cmds
2 participants
@xiangpingjiang @dsimansk