-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop replace directives #1154
drop replace directives #1154
Conversation
/assign @skonto |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 11 11
Lines 938 938
=======================================
Hits 885 885
Misses 32 32
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Will do linting in another pass /override "style / Golang / Lint" |
@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
af1be80
into
knative-extensions:main
No description provided.